Sign upLogin

mrDoctorWho/vk4xmpp

View on GitHub
Star
library/xmpp/client.py

Summary

Maintainability
D
2 days
Test Coverage

File client.py has 334 lines of code (exceeds 250 allowed). Consider refactoring.
Open

##   client.py
##
##   Copyright (C) 2003-2005 Alexey "Snake" Nezhdanov
##
##   This program is free software; you can redistribute it and/or modify
Severity: Minor
Found in library/xmpp/client.py - About 4 hrs to fix

    Function auth has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        def auth(self, user, password, resource="", sasl=1):
        """
        Authenticate connnection and bind resource. If resource is not provided
        random one or library name used.
        """
    Severity: Minor
    Found in library/xmpp/client.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function connect has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        def connect(self, server=None, proxy=None, ssl=None, use_srv=False):
        """
        Make a tcp/ip connection, protect it with tls/ssl if possible and start XMPP stream.
        Returns None or "tcp" or "tls", depending on the result.
        """
    Severity: Minor
    Found in library/xmpp/client.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function connect has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def connect(self, server=None, proxy=None, secure=None, use_srv=True):
        """
        Connect to jabber server. If you want to specify different ip/port to connect to you can
        pass it as tuple as first parameter. If there is HTTP proxy between you and server
        specify it's address and credentials (if needed) in the second argument.
    Severity: Minor
    Found in library/xmpp/client.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function reconnectAndReauth has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def reconnectAndReauth(self, handlerssave=None):
        """
        Example of reconnection method. In fact, it can be used to batch connection and auth as well.
        """
        Dispatcher_ = False
    Severity: Minor
    Found in library/xmpp/client.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, transport, port=5347, typ=None, debug=["always", "nodebuilder"], domains=None, sasl=0, bind=0, route=0, xcp=0):
    Severity: Major
    Found in library/xmpp/client.py - About 1 hr to fix

      Function auth has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def auth(self, name, password, dup=None):
        """
        Authenticate component "name" with password "password".
        """
        self._User, self._Password, self._Resource = name, password, ""
      Severity: Minor
      Found in library/xmpp/client.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function dobind has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def dobind(self, sasl):
        # This has to be done before binding, because we can receive a route stanza before binding finishes
        self._route = self.route
        if self.bind:
            for domain in self.domains:
      Severity: Minor
      Found in library/xmpp/client.py - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

                  return self.connected
      Severity: Major
      Found in library/xmpp/client.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return self.connected
        Severity: Major
        Found in library/xmpp/client.py - About 30 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if "version" in self.Dispatcher.Stream._document_attrs and self.Dispatcher.Stream._document_attrs["version"] == "1.0":
            while not self.Dispatcher.Stream.features and self.Process(1):
          Severity: Major
          Found in library/xmpp/client.py and 1 other location - About 3 hrs to fix
          library/xmpp/client.py on lines 242..243

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if "version" in self.Dispatcher.Stream._document_attrs and self.Dispatcher.Stream._document_attrs["version"] == "1.0":
            while not self.Dispatcher.Stream.features and self.Process(1):
          Severity: Major
          Found in library/xmpp/client.py and 1 other location - About 3 hrs to fix
          library/xmpp/client.py on lines 195..196

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status