Sign upLogin

mrDoctorWho/vk4xmpp

View on GitHub
Star
library/xmpp/commands.py

Summary

Maintainability
C
1 day
Test Coverage

File commands.py has 356 lines of code (exceeds 250 allowed). Consider refactoring.
Open

## Ad-Hoc Command manager

## Mike Albon (c) 5th January 2005

##   This program is free software; you can redistribute it and/or modify
Severity: Minor
Found in library/xmpp/commands.py - About 4 hrs to fix

    Function _DiscoHandler has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        def _DiscoHandler(self, conn, request, typ):
        """
        The internal method to process service discovery requests.
        """
        # This is the disco manager handler.
    Severity: Minor
    Found in library/xmpp/commands.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function Execute has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def Execute(self, conn, request):
        """
        The method that handles all the commands, and routes them to the correct method for that stage.
        """
        # New request or old?
    Severity: Minor
    Found in library/xmpp/commands.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _CommandHandler has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def _CommandHandler(self, conn, request):
        """
        The internal method to process the routing of command execution requests.
        """
        # This is the command handler itself.
    Severity: Minor
    Found in library/xmpp/commands.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status