Sign upLogin

mrDoctorWho/vk4xmpp

View on GitHub
Star
library/xmpp/features.py

Summary

Maintainability
C
7 hrs
Test Coverage

Function discoverInfo has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

def discoverInfo(disp, jid, node=None):
    """
    Query remote object about info that it publishes. Returns identities and features lists.
    """
    identities, features = [], []
Severity: Minor
Found in library/xmpp/features.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _discover has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def _discover(disp, ns, jid, node=None, fb2b=0, fb2a=1):
Severity: Minor
Found in library/xmpp/features.py - About 45 mins to fix

    Function getPrivacyLists has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def getPrivacyLists(disp):
    """
    Requests privacy lists from connected server.
    Returns dictionary of existing lists on success.
    """
    Severity: Minor
    Found in library/xmpp/features.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _ReceivedRegInfo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def _ReceivedRegInfo(con, resp, agent):
    iq = Iq("get", NS_REGISTER, to=agent)
    if not isResultNode(resp):
        return None
    df = resp.getTag("query", namespace=NS_REGISTER).getTag("x", namespace=NS_DATA)
    Severity: Minor
    Found in library/xmpp/features.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if fb2b and not isResultNode(rep):
        rep = disp.SendAndWaitForResponse(Iq(to=jid, typ="get", queryNS=NS_BROWSE)) # Fallback to browse
    Severity: Major
    Found in library/xmpp/features.py and 1 other location - About 1 hr to fix
    library/xmpp/features.py on lines 44..45

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if fb2a and not isResultNode(rep):
        rep = disp.SendAndWaitForResponse(Iq(to=jid, typ="get", queryNS=NS_AGENTS)) # Fallback to agents
    Severity: Major
    Found in library/xmpp/features.py and 1 other location - About 1 hr to fix
    library/xmpp/features.py on lines 42..43

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status