Sign upLogin

mrDoctorWho/vk4xmpp

View on GitHub
Star
modules/mod_groupchat_prs.py

Summary

Maintainability
C
1 day
Test Coverage

Function handleChatPresences has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

def handleChatPresences(source, prs):
    """
    Makes the old users leave
    Args:
        source: stanza source
Severity: Minor
Found in modules/mod_groupchat_prs.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function handleChatErrors has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

def handleChatErrors(source, prs):
    """
    Handles error presences from groupchats
    Args:
        source: the source jid
Severity: Minor
Found in modules/mod_groupchat_prs.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if (time.gmtime().tm_mon, time.gmtime().tm_mday) == (4, 1):
                        setAffiliation(source, "outcast", jid, reason=_("Get the hell outta here!"))
                    else:
                        leaveChat(source, jid)
Severity: Major
Found in modules/mod_groupchat_prs.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                        if jid != TransportID:
                        runDatabaseQuery("update groupchats set owner=? where jid=?", (source, jid), set=True)
    Severity: Major
    Found in modules/mod_groupchat_prs.py - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status