Sign upLogin

mrVragec/MMM-mvgmunich

View on GitHub
Star

Showing 8 of 8 total issues

Function getHtml has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    getHtml: function (jsonObject) {
        let htmlText = "";

        let visibleLines = 0;
        const interruptions = new Set();
Severity: Minor
Found in mvgmunich.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(grunt) {
    require("time-grunt")(grunt);
    grunt.initConfig({
        pkg: grunt.file.readJSON("package.json"),
        eslint: {
Severity: Major
Found in Gruntfile.js - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if (this.config.trainDepartureTimeFormat === "absolute") {
                htmlText += this.getAbsoluteTime(departureDate);
            } else if (this.config.trainDepartureTimeFormat === "relative") {
                htmlText += this.getRelativeTime(departureDate);
            } else {
    Severity: Major
    Found in mvgmunich.js and 1 other location - About 2 hrs to fix
    mvgmunich.js on lines 203..209

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 82.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if (this.config.walkingTimeFormat === "absolute") {
                htmlText += this.getAbsoluteTime(startWalkingTime);
            } else if (this.config.walkingTimeFormat === "relative") {
                htmlText += this.getRelativeTime(startWalkingTime);
            } else {
    Severity: Major
    Found in mvgmunich.js and 1 other location - About 2 hrs to fix
    mvgmunich.js on lines 223..229

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 82.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function getHtml has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        getHtml: function (jsonObject) {
        let htmlText = "";

        let visibleLines = 0;
        const interruptions = new Set();
    Severity: Minor
    Found in mvgmunich.js - About 1 hr to fix

      Function getInterruptionsDetails has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          getInterruptionsDetails: function (lineName) {
        for (let i = 0; i < this.interruptionData.interruption.length; i++) {
            if (this.interruptionData.interruption[i].lines.line != null) {
                for (let j = 0; j < this.interruptionData.interruption[i].lines.line.length; j++) {
                    if (this.interruptionData.interruption[i].lines.line[j].line === lineName) {
      Severity: Minor
      Found in mvgmunich.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getStationInfo has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          getStationInfo: function (payload) {
        const self = this;
        request({
            headers: globals,
            uri: stationQuery + urlencode(payload.haltestelle),
      Severity: Minor
      Found in node_helper.js - About 1 hr to fix

        Function isLineAffected has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            isLineAffected: function (lineName) {
        if (this.interruptionData.affectedLines != undefined) {
            for (let i = 0; i < this.interruptionData.affectedLines.line.length; i++) {
                if (this.interruptionData.affectedLines.line[i].line === lineName) {
                    return true;
        Severity: Minor
        Found in mvgmunich.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language