mrcnpdlk/grandstream-xmlapp

Method resizeImage has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private function resizeImage(int $width = 100, int $height = null)
    {
        if (!file_exists($this->sImgPath) || !is_readable($this->sImgPath)) {
            throw new Exception('Image not exists');
        }

Method toGreyScale has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private function toGreyScale(int $tone = null)
    {
        if (is_null($tone)) {
            return 'None';
        }

The method setVisibleStatusLine has a boolean flag argument $isVisible, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function setVisibleStatusLine(bool $isVisible = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Missing class import via use statement (line '32', column '27').

Open

        $this->oXml = new \SimpleXMLElement(sprintf('<?xml version="1.0" encoding="UTF-8"?><%s></%s>', $nodeRootName, $nodeRootName));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

The method setVisibleStatusLine has a boolean flag argument $isVisible, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function setVisibleStatusLine(bool $isVisible = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Missing class import via use statement (line '141', column '47').

Open

        $imagick->setImageBackgroundColor(new \ImagickPixel('white'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '151', column '23').

Open

        $canvas = new \Imagick();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

The method setSelected has a boolean flag argument $isSelected, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function setSelected(bool $isSelected = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Missing class import via use statement (line '152', column '48').

Open

        $canvas->newImage($width, $height, new \ImagickPixel('white'));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Missing class import via use statement (line '123', column '24').

Open

        $imagick = new \Imagick(realpath($this->sImgPath));

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

The method ignoreCallUpdate has a boolean flag argument $ignoreCallUpdate, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function ignoreCallUpdate(bool $ignoreCallUpdate = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Missing class import via use statement (line '76', column '40').

Open

        $dom                     = new \DOMDocument("1.0", 'UTF-8');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

The method resizeImage uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {//za wysoki
            $imgHeight = $height;
            $imgWidth  = intval($height * $origFactor);
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}