Function __construct
has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring. Open
public function __construct(\stdClass $oData = null, \stdClass $oLayers = null)
{
parent::__construct($oData);
if ($oData) {
$this->id = $this->convertToId($this->id);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method __construct
has 86 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function __construct(\stdClass $oData = null, \stdClass $oLayers = null)
{
parent::__construct($oData);
if ($oData) {
$this->id = $this->convertToId($this->id);
The class KrsEntity has 77 fields. Consider redesigning KrsEntity to keep the number of fields under 15. Open
class KrsEntity extends ModelAbstract
{
const CONTEXT = 'krs_podmioty';
const PULL_NONE = 0;
const PULL_COMPANIES = 1;
- Read upRead up
- Exclude checks
TooManyFields
Since: 0.1
Classes that have too many fields could be redesigned to have fewer fields, possibly through some nested object grouping of some of the information. For example, a class with city/state/zip fields could instead have one Address field.
Example
class Person {
protected $one;
private $two;
private $three;
[... many more fields ...]
}
Source https://phpmd.org/rules/codesize.html#toomanyfields
The class KrsEntity has 78 public methods and attributes. Consider reducing the number of public items to less than 45. Open
class KrsEntity extends ModelAbstract
{
const CONTEXT = 'krs_podmioty';
const PULL_NONE = 0;
const PULL_COMPANIES = 1;
- Read upRead up
- Exclude checks
ExcessivePublicCount
Since: 0.1
A large number of public methods and attributes declared in a class can indicate the class may need to be broken up as increased effort will be required to thoroughly test it.
Example
public class Foo {
public $value;
public $something;
public $var;
// [... more more public attributes ...]
public function doWork() {}
public function doMoreWork() {}
public function doWorkAgain() {}
// [... more more public methods ...]
}
Source https://phpmd.org/rules/codesize.html#excessivepubliccount
The method __construct() has an NPath complexity of 1003884. The configured NPath complexity threshold is 200. Open
public function __construct(\stdClass $oData = null, \stdClass $oLayers = null)
{
parent::__construct($oData);
if ($oData) {
$this->id = $this->convertToId($this->id);
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method __construct() has a Cyclomatic Complexity of 28. The configured cyclomatic complexity threshold is 10. Open
public function __construct(\stdClass $oData = null, \stdClass $oLayers = null)
{
parent::__construct($oData);
if ($oData) {
$this->id = $this->convertToId($this->id);
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Missing class import via use statement (line '512', column '79'). Open
$this->data_sprawdzenia = $this->data_sprawdzenia ? (new \DateTime($this->data_sprawdzenia))->format('Y-m-d H:i:s') : null;
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}