Sign upLogin

mrcnpdlk/validator

View on GitHub
Star
src/mrcnpdlk/Validator/Types/IDCard.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method isValid has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function isValid($checkedValue, bool $asEx = false): bool
    {
        try {
            static::isValidType($checkedValue, static::TYPE_STRING, true);
            if (!preg_match('/^[A-NPR-Z]{3}[0-9]{6}$/', $checkedValue)) {
Severity: Major
Found in src/mrcnpdlk/Validator/Types/IDCard.php - About 2 hrs to fix

    Function isValid has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function isValid($checkedValue, bool $asEx = false): bool
    {
        try {
            static::isValidType($checkedValue, static::TYPE_STRING, true);
            if (!preg_match('/^[A-NPR-Z]{3}[0-9]{6}$/', $checkedValue)) {
    Severity: Minor
    Found in src/mrcnpdlk/Validator/Types/IDCard.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Missing class import via use statement (line '78', column '27').
    Open

                    throw new \Exception(sprintf('Checksum error'), 1);
    Severity: Minor
    Found in src/mrcnpdlk/Validator/Types/IDCard.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '28', column '27').
    Open

                    throw new \Exception("Regexp error", 1);
    Severity: Minor
    Found in src/mrcnpdlk/Validator/Types/IDCard.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    There are no issues that match your filters.

    Category
    Status