Function searchByTitleNative
has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring. Open
public function searchByTitleNative(string $title): array
{
try {
/**
* @var Title[] $answer
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method searchByTitleNative
has 102 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function searchByTitleNative(string $title): array
{
try {
/**
* @var Title[] $answer
File Imdb.php
has 255 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* xMDB-API
*
* Copyright © 2017 pudelek.org.pl
Method getRating
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getRating(string $imdbId): Rating
{
try {
$searchUrl = 'http://p.media-imdb.com/static-content/documents/v1/title/'
. $imdbId
Method searchByTitleApi
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function searchByTitleApi(string $title): array
{
try {
$answer = [];
$tList = $this->getApiTitleSearch()->search($title, [
Method searchByTitle
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function searchByTitle(string $title, int $limit = null, Ratio $oRatio = null): array
{
/**
* @var Title[] $answer
* @var Title[] $tmpList
Function searchByTitle
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
public function searchByTitle(string $title, int $limit = null, Ratio $oRatio = null): array
{
/**
* @var Title[] $answer
* @var Title[] $tmpList
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method searchByTitleNative() has 120 lines of code. Current threshold is set to 100. Avoid really long methods. Open
public function searchByTitleNative(string $title): array
{
try {
/**
* @var Title[] $answer
- Exclude checks
The method searchByTitleNative() has an NPath complexity of 13443. The configured NPath complexity threshold is 200. Open
public function searchByTitleNative(string $title): array
{
try {
/**
* @var Title[] $answer
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method searchByTitleNative() has a Cyclomatic Complexity of 21. The configured cyclomatic complexity threshold is 10. Open
public function searchByTitleNative(string $title): array
{
try {
/**
* @var Title[] $answer
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The class Imdb has a coupling between objects value of 17. Consider to reduce the number of dependencies under 13. Open
class Imdb
{
/**
* @var \mrcnpdlk\Xmdb\Client
*/
- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}
Source https://phpmd.org/rules/design.html#couplingbetweenobjects
Missing class import via use statement (line '283', column '27'). Open
throw new \RuntimeException('Response from IMDB malformed!');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '296', column '31'). Open
throw new \RuntimeException('Title not found!');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '139', column '27'). Open
throw new \RuntimeException('Resource is empty');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '126', column '39'). Open
throw new \RuntimeException('Curl Error! ' . Http::message($oCurl->httpStatusCode), $oCurl->error_code);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Missing class import via use statement (line '290', column '31'). Open
throw new \RuntimeException('Empty search result!');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class '\HttpLib\Http' in method 'getRating'. Open
throw new \RuntimeException('Curl Error! ' . Http::message($oCurl->httpStatusCode), $oCurl->error_code);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method searchByTitleNative uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
throw new \RuntimeException('Title not found!');
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\Sunra\PhpSimple\HtmlDomParser' in method 'searchByTitleNative'. Open
$html = HtmlDomParser::str_get_html($htmlContent);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Campo\UserAgent' in method '__construct'. Open
$this->oConfig->default_agent = UserAgent::random();
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The method searchByTitle uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$tmpList[$item->imdbId]->isMovie = $tmpList[$item->imdbId]->isMovie ?? $item->isMovie;
$tmpList[$item->imdbId]->type = $tmpList[$item->imdbId]->type ?? $item->type;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method searchByTitleNative uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$foundYear = null;
$foundType = null;
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class '\Campo\UserAgent' in method 'getRating'. Open
$oCurl->setUserAgent(UserAgent::random());
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
The variable $output_array is not named in camelCase. Open
public function getRating(string $imdbId): Rating
{
try {
$searchUrl = 'http://p.media-imdb.com/static-content/documents/v1/title/'
. $imdbId
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $output_array is not named in camelCase. Open
public function getRating(string $imdbId): Rating
{
try {
$searchUrl = 'http://p.media-imdb.com/static-content/documents/v1/title/'
. $imdbId
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}