src/Model/Omdb/Title.php
Method create has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public static function create(\stdClass $oData)
{
$oTitle = new static();
$oTitle->title = $oData->Title;
$oTitle->titleOrg = $oData->Title;The method create() has an NPath complexity of 512. The configured NPath complexity threshold is 200. Open
Open
public static function create(\stdClass $oData)
{
$oTitle = new static();
$oTitle->title = $oData->Title;
$oTitle->titleOrg = $oData->Title;- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method create() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10. Open
Open
public static function create(\stdClass $oData)
{
$oTitle = new static();
$oTitle->title = $oData->Title;
$oTitle->titleOrg = $oData->Title;- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}