Sign upLogin

mrksbrg/ImpRec

View on GitHub
Star
Logic/KnowlParser.cs

Summary

Maintainability
D
2 days
Test Coverage

File KnowlParser.cs has 348 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using System;
using System.Collections;
using System.Collections.Generic;
using System.Linq;
using System.Text;
Severity: Minor
Found in Logic/KnowlParser.cs - About 4 hrs to fix

    Method StartTextElement has 96 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            private void StartTextElement(string strText)
        {
            if (nodeMode == 1) // Tracker case
            {
                if (currentTrackerCase == null)
    Severity: Major
    Found in Logic/KnowlParser.cs - About 3 hrs to fix

      Method StartElement has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              private void StartElement(string strURI, string strName, string strName_2, Hashtable attributes)
        {
            if (strName == "TrackerCase")
            {
                nodeMode = 1;
      Severity: Major
      Found in Logic/KnowlParser.cs - About 2 hrs to fix

        Method ParseImpactAnalyses has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                public void ParseImpactAnalyses()
        {
            string line;

            // Read the file line by line
        Severity: Minor
        Found in Logic/KnowlParser.cs - About 1 hr to fix

          Method ParseSemNet has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  public void ParseSemNet()
        {
            try
            {
                XDocument doc = XDocument.Parse(ImpRec.Properties.Resources.semanticNetwork);
          Severity: Minor
          Found in Logic/KnowlParser.cs - About 1 hr to fix

            Method ParseIssueText has 40 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    public void ParseIssueText()
        {
            int lineType = 1; // 1 = id, 2 = title, 3 = desc, 4 = blank
            string line;
            TrackerCase tmpCase = null;
            Severity: Minor
            Found in Logic/KnowlParser.cs - About 1 hr to fix

              Method StartTextElement has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
              Open

                      private void StartTextElement(string strText)
        {
            if (nodeMode == 1) // Tracker case
            {
                if (currentTrackerCase == null)
              Severity: Minor
              Found in Logic/KnowlParser.cs - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Consider simplifying this complex logical expression.
              Open

                              if (line.Length == 27 && Char.IsDigit(line[17]) && Char.IsDigit(line[18]) && Char.IsDigit(line[19]) && 
                    Char.IsDigit(line[20]) && Char.IsDigit(line[21]))
                {
                    currentTrackerCase = kb.GetTrackerCase(line.Substring(17, 5), false);
                    currentIAReport = "";
              Severity: Major
              Found in Logic/KnowlParser.cs - About 40 mins to fix

                Method ParseImpactAnalyses has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
                Open

                        public void ParseImpactAnalyses()
        {
            string line;

            // Read the file line by line
                Severity: Minor
                Found in Logic/KnowlParser.cs - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                            {
                ImpactItem dest = kb.GetImpactItem(strText);
                try
                {
                    dest.NbrInLinks++;
                Severity: Major
                Found in Logic/KnowlParser.cs and 3 other locations - About 30 mins to fix
                Logic/KnowlParser.cs on lines 305..317
                Logic/KnowlParser.cs on lines 319..330
                Logic/KnowlParser.cs on lines 332..343

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 61.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                            {
                ImpactItem dest = kb.GetImpactItem(strText);
                try
                {
                    dest.NbrInLinks++;
                Severity: Major
                Found in Logic/KnowlParser.cs and 3 other locations - About 30 mins to fix
                Logic/KnowlParser.cs on lines 319..330
                Logic/KnowlParser.cs on lines 332..343
                Logic/KnowlParser.cs on lines 345..356

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 61.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                            {
                ImpactItem dest = kb.GetImpactItem(strText);
                try
                {
                    dest.NbrInLinks++;
                Severity: Major
                Found in Logic/KnowlParser.cs and 3 other locations - About 30 mins to fix
                Logic/KnowlParser.cs on lines 305..317
                Logic/KnowlParser.cs on lines 332..343
                Logic/KnowlParser.cs on lines 345..356

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 61.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                            {
                ImpactItem dest = kb.GetImpactItem(strText);
                try
                {
                    dest.NbrInLinks++;
                Severity: Major
                Found in Logic/KnowlParser.cs and 3 other locations - About 30 mins to fix
                Logic/KnowlParser.cs on lines 305..317
                Logic/KnowlParser.cs on lines 319..330
                Logic/KnowlParser.cs on lines 345..356

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 61.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status