mrksbrg/ImpRec

View on GitHub

Showing 33 of 33 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        {
            TextWriter writer;
            if (!File.Exists(FILENAME))
            {
                writer = new StreamWriter(FILENAME);
Severity: Major
Found in Logic/SessionInfo.cs and 2 other locations - About 1 hr to fix
Logic/SessionInfo.cs on lines 76..89
Logic/SessionInfo.cs on lines 121..133

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        {
            TextWriter writer;
            if (!File.Exists(FILENAME))
            {
                writer = new StreamWriter(FILENAME);
Severity: Major
Found in Logic/SessionInfo.cs and 2 other locations - About 1 hr to fix
Logic/SessionInfo.cs on lines 76..89
Logic/SessionInfo.cs on lines 99..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        {
            TextWriter writer;
            if (!File.Exists(FILENAME))
            {
                writer = new StreamWriter(FILENAME);
Severity: Major
Found in Logic/SessionInfo.cs and 2 other locations - About 1 hr to fix
Logic/SessionInfo.cs on lines 99..111
Logic/SessionInfo.cs on lines 121..133

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method lstRelated_SelectedIndexChanged has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        private void lstRelated_SelectedIndexChanged(object sender, EventArgs e)
        {
            // Reset all selections in lstImpacted
            for (int k = 0; k < lstImpacted.Items.Count; k++)
            {
Severity: Minor
Found in UI/ImpRecGUI.cs - About 1 hr to fix

    Method StartTextElement has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
    Open

            private void StartTextElement(string strText)
            {
                if (nodeMode == 1) // Tracker case
                {
                    if (currentTrackerCase == null)
    Severity: Minor
    Found in Logic/KnowlParser.cs - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                                if (ii.ArtifactID.Equals(lstImpacted.Items[j].SubItems[2].Text))
                                {
                                    lstImpacted.Items[j].BackColor = Color.LightBlue;
    
                                    if (j < posOfHighest)
    Severity: Major
    Found in UI/ImpRecGUI.cs - About 45 mins to fix

      Consider simplifying this complex logical expression.
      Open

                      if (line.Length == 27 && Char.IsDigit(line[17]) && Char.IsDigit(line[18]) && Char.IsDigit(line[19]) && 
                          Char.IsDigit(line[20]) && Char.IsDigit(line[21]))
                      {
                          currentTrackerCase = kb.GetTrackerCase(line.Substring(17, 5), false);
                          currentIAReport = "";
      Severity: Major
      Found in Logic/KnowlParser.cs - About 40 mins to fix

        Method lstRelated_SelectedIndexChanged has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
        Open

                private void lstRelated_SelectedIndexChanged(object sender, EventArgs e)
                {
                    // Reset all selections in lstImpacted
                    for (int k = 0; k < lstImpacted.Items.Count; k++)
                    {
        Severity: Minor
        Found in UI/ImpRecGUI.cs - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                    {
                        ImpactItem dest = kb.GetImpactItem(strText);
                        try
                        {
                            dest.NbrInLinks++;
        Severity: Major
        Found in Logic/KnowlParser.cs and 3 other locations - About 30 mins to fix
        Logic/KnowlParser.cs on lines 305..317
        Logic/KnowlParser.cs on lines 319..330
        Logic/KnowlParser.cs on lines 332..343

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 61.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                    {
                        ImpactItem dest = kb.GetImpactItem(strText);
                        try
                        {
                            dest.NbrInLinks++;
        Severity: Major
        Found in Logic/KnowlParser.cs and 3 other locations - About 30 mins to fix
        Logic/KnowlParser.cs on lines 319..330
        Logic/KnowlParser.cs on lines 332..343
        Logic/KnowlParser.cs on lines 345..356

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 61.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                    {
                        ImpactItem dest = kb.GetImpactItem(strText);
                        try
                        {
                            dest.NbrInLinks++;
        Severity: Major
        Found in Logic/KnowlParser.cs and 3 other locations - About 30 mins to fix
        Logic/KnowlParser.cs on lines 305..317
        Logic/KnowlParser.cs on lines 332..343
        Logic/KnowlParser.cs on lines 345..356

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 61.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                    {
                        ImpactItem dest = kb.GetImpactItem(strText);
                        try
                        {
                            dest.NbrInLinks++;
        Severity: Major
        Found in Logic/KnowlParser.cs and 3 other locations - About 30 mins to fix
        Logic/KnowlParser.cs on lines 305..317
        Logic/KnowlParser.cs on lines 319..330
        Logic/KnowlParser.cs on lines 345..356

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 61.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method ParseImpactAnalyses has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
        Open

                public void ParseImpactAnalyses()
                {
                    string line;
        
                    // Read the file line by line
        Severity: Minor
        Found in Logic/KnowlParser.cs - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language