Sign upLogin

mrksbrg/RacketGhost

View on GitHub
Star
app/src/main/java/com/markusborg/logic/Setting.java

Summary

Maintainability
B
6 hrs
Test Coverage

Consider simplifying this complex logical expression.
Open

        if (!Character.isDigit(date.charAt(0)) ||
                !Character.isDigit(date.charAt(1)) ||
                !Character.isDigit(date.charAt(2)) ||
                !Character.isDigit(date.charAt(3)) ||
                date.charAt(4) != '-' ||
Severity: Critical
Found in app/src/main/java/com/markusborg/logic/Setting.java - About 2 hrs to fix

    Method setSettingFromString has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private boolean setSettingFromString(String input) {
        // Example of valid string
        // 2015-11-24 (SQ): 1; 1; 1; 1

        // shortest possible string is 27 characters
    Severity: Minor
    Found in app/src/main/java/com/markusborg/logic/Setting.java - About 1 hr to fix

      Method setSettingFromString has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          private boolean setSettingFromString(String input) {
        // Example of valid string
        // 2015-11-24 (SQ): 1; 1; 1; 1

        // shortest possible string is 27 characters
      Severity: Minor
      Found in app/src/main/java/com/markusborg/logic/Setting.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return true;
      Severity: Major
      Found in app/src/main/java/com/markusborg/logic/Setting.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return false;
        Severity: Major
        Found in app/src/main/java/com/markusborg/logic/Setting.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return false;
          Severity: Major
          Found in app/src/main/java/com/markusborg/logic/Setting.java - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status