Sign upLogin

mrksbrg/RacketGhost

View on GitHub
Star
app/src/main/java/com/markusborg/ui/GhostingActivity.java

Summary

Maintainability
F
3 days
Test Coverage

Method onProgressUpdate has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

        @Override
        protected void onProgressUpdate(String... progress) {
            if (progress == null) {
                Toast toast = Toast.makeText(getApplicationContext(), "Set completed!", Toast.LENGTH_SHORT);
                toast.show();
Severity: Minor
Found in app/src/main/java/com/markusborg/ui/GhostingActivity.java - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File GhostingActivity.java has 359 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package com.markusborg.ui;

import android.annotation.TargetApi;
import android.content.Intent;
import android.graphics.drawable.Drawable;
Severity: Minor
Found in app/src/main/java/com/markusborg/ui/GhostingActivity.java - About 4 hrs to fix

    Method doInBackground has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

            @Override
        protected String doInBackground(Setting... params) {
            Setting theSetting = params[0];
            GhostPlayer theGhost = new GhostPlayer(theSetting.isSixPoints());
    Severity: Minor
    Found in app/src/main/java/com/markusborg/ui/GhostingActivity.java - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method onProgressUpdate has 72 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            @Override
        protected void onProgressUpdate(String... progress) {
            if (progress == null) {
                Toast toast = Toast.makeText(getApplicationContext(), "Set completed!", Toast.LENGTH_SHORT);
                toast.show();
    Severity: Major
    Found in app/src/main/java/com/markusborg/ui/GhostingActivity.java - About 2 hrs to fix

      Method onCreate has 58 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_ghosting);
        Bundle extras = getIntent().getExtras();
      Severity: Major
      Found in app/src/main/java/com/markusborg/ui/GhostingActivity.java - About 2 hrs to fix

        Method doInBackground has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                @Override
        protected String doInBackground(Setting... params) {
            Setting theSetting = params[0];
            GhostPlayer theGhost = new GhostPlayer(theSetting.isSixPoints());
        Severity: Minor
        Found in app/src/main/java/com/markusborg/ui/GhostingActivity.java - About 1 hr to fix

          Method displayCountdown has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  private void displayCountdown() {
            publishProgress("5");
            try {
                Thread.sleep(1000);
            } catch (InterruptedException e) {
          Severity: Minor
          Found in app/src/main/java/com/markusborg/ui/GhostingActivity.java - About 1 hr to fix

            Method onCreate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_ghosting);
        Bundle extras = getIntent().getExtras();
            Severity: Minor
            Found in app/src/main/java/com/markusborg/ui/GhostingActivity.java - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method setBackgroundImage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                @SuppressWarnings("deprecation")
    private void setBackgroundImage(int mode) {
        Drawable d = null;
        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
            d = getBackgroundImageNew(BADMINTON_MODE);
            Severity: Minor
            Found in app/src/main/java/com/markusborg/ui/GhostingActivity.java - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                            else if (cornerToFlash.equals("L_MID")) {
                    ball = (ImageView) findViewById(R.id.ballLeftMid);
                    if (mLoaded) {
                        mSoundPool.play(mSoundIDs[5], 1.0f, 0.1f, 1, 0, 1.0f);
                    }
            Severity: Major
            Found in app/src/main/java/com/markusborg/ui/GhostingActivity.java and 5 other locations - About 35 mins to fix
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 411..416
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 399..404
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 393..398
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 387..392
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 381..386

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                            else if (cornerToFlash.equals("R_BACK")) {
                    ball = (ImageView) findViewById(R.id.ballRightBack);
                    if (mLoaded) {
                        mSoundPool.play(mSoundIDs[3], 0.1f, 1.0f, 1, 0, 1.0f);
                    }
            Severity: Major
            Found in app/src/main/java/com/markusborg/ui/GhostingActivity.java and 5 other locations - About 35 mins to fix
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 411..416
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 405..410
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 393..398
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 387..392
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 381..386

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                            else if (cornerToFlash.equals("L_BACK")) {
                    ball = (ImageView) findViewById(R.id.ballLeftBack);
                    if (mLoaded) {
                        mSoundPool.play(mSoundIDs[4], 1.0f, 0.1f, 1, 0, 1.0f);
                    }
            Severity: Major
            Found in app/src/main/java/com/markusborg/ui/GhostingActivity.java and 5 other locations - About 35 mins to fix
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 411..416
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 405..410
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 399..404
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 387..392
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 381..386

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                            else if (cornerToFlash.equals("R_FRONT")) {
                    ball = (ImageView) findViewById(R.id.ballRightFront);
                    if (mLoaded) {
                        mSoundPool.play(mSoundIDs[1], 0.1f, 1.0f, 1, 0, 1.0f);
                    }
            Severity: Major
            Found in app/src/main/java/com/markusborg/ui/GhostingActivity.java and 5 other locations - About 35 mins to fix
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 411..416
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 405..410
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 399..404
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 393..398
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 381..386

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                            else {
                    ball = (ImageView) findViewById(R.id.ballRightMid);
                    if (mLoaded) {
                        mSoundPool.play(mSoundIDs[2], 0.1f, 1.0f, 1, 0, 1.0f);
                    }
            Severity: Major
            Found in app/src/main/java/com/markusborg/ui/GhostingActivity.java and 5 other locations - About 35 mins to fix
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 405..410
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 399..404
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 393..398
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 387..392
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 381..386

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                            if (cornerToFlash.equals("L_FRONT")) {
                    ball = (ImageView) findViewById(R.id.ballLeftFront);
                    if (mLoaded) {
                        mSoundPool.play(mSoundIDs[0], 1.0f, 0.1f, 1, 0, 1.0f);
                    }
            Severity: Major
            Found in app/src/main/java/com/markusborg/ui/GhostingActivity.java and 5 other locations - About 35 mins to fix
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 411..416
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 405..410
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 399..404
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 393..398
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 387..392

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
            d = getBackgroundImageNew(BADMINTON_MODE);
        }
        else {
            d = getBackgroundImageOld(BADMINTON_MODE);
            Severity: Minor
            Found in app/src/main/java/com/markusborg/ui/GhostingActivity.java and 1 other location - About 30 mins to fix
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 140..144

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 40.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
            ballIcon = getBallIconNew(ballType);
        } else {
            ballIcon = getBallIconOld(ballType);
        }
            Severity: Minor
            Found in app/src/main/java/com/markusborg/ui/GhostingActivity.java and 1 other location - About 30 mins to fix
            app/src/main/java/com/markusborg/ui/GhostingActivity.java on lines 166..171

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 40.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status