Sign upLogin

mrtazz/checkmake

View on GitHub
Star

Showing 9 of 9 total issues

Function Parse has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
Open

func Parse(filepath string) (ret Makefile, err error) {

    ret.FileName = filepath
    var scanner *MakefileScanner
    scanner, err = NewMakefileScanner(filepath)
Severity: Minor
Found in parser/parser.go - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func TestGetConfigValueOnMissingDefaultSection(t *testing.T) {

    cfg, err := NewConfigFromFile("../fixtures/exampleConfigNoDefault.ini")

    require.Equal(t, nil, err, "Parsing of the fixture config file should have worked.")
Severity: Minor
Found in config/config_test.go and 1 other location - About 35 mins to fix
config/config_test.go on lines 63..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function Parse has 5 return statements (exceeds 4 allowed).
Open

func Parse(filepath string) (ret Makefile, err error) {

    ret.FileName = filepath
    var scanner *MakefileScanner
    scanner, err = NewMakefileScanner(filepath)
Severity: Major
Found in parser/parser.go - About 35 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func TestGetMissingConfigValue(t *testing.T) {

    cfg, err := NewConfigFromFile("../fixtures/exampleConfig.ini")

    require.Equal(t, nil, err, "Parsing of the fixture config file should have worked.")
    Severity: Minor
    Found in config/config_test.go and 1 other location - About 35 mins to fix
    config/config_test.go on lines 76..88

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Your code does not pass gofmt in 2 places. Go fmt your code!
    Open

    package timestampexpanded
    Severity: Minor
    Found in rules/timestampexpanded/timestampexpanded_test.go by gofmt

    Your code does not pass gofmt in 2 places. Go fmt your code!
    Open

    package phonydeclared
    Severity: Minor
    Found in rules/phonydeclared/phonydeclared_test.go by gofmt

    Your code does not pass gofmt in 1 place. Go fmt your code!
    Open

    package minphony
    Severity: Minor
    Found in rules/minphony/minphony_test.go by gofmt

    Your code does not pass gofmt in 1 place. Go fmt your code!
    Open

    // Package parser implements all the parser functionality for Makefiles. This
    Severity: Minor
    Found in parser/parser.go by gofmt

    2: cannot find package "github.com/docopt/docopt-go" in any of:
    Open

    Severity: Minor
    Found in checkmake.go by govet
    Severity
    Category
    Status
    Source
    Language