Sign upLogin

mrtazz/yagd

View on GitHub
Star

Showing 9 of 9 total issues

Method getHeader has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getHeader(
        $title = null,
        $navItems = [],
        $selectbox = null,
        $times = null
Severity: Major
Found in phplib/Page.php - About 2 hrs to fix

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $graphitehost,
        $from = null,
        $title = null,
        $hideLegend = null,
        $width = null
    Severity: Minor
    Found in phplib/GraphiteGraph.php - About 35 mins to fix

      Blank line found at end of control structure
      Open
      Severity: Minor
      Found in phplib/CollectdHost.php by phpcodesniffer

      Function closing brace must go on the next line following the body; found 1 blank lines before brace
      Open

          }
      Severity: Minor
      Found in phplib/Page.php by phpcodesniffer

      Blank line found at end of control structure
      Open
      Severity: Minor
      Found in phplib/CollectdHost.php by phpcodesniffer

      Missing class import via use statement (line '66', column '23').
      Open

                  throw new \Exception($msg);
      Severity: Minor
      Found in phplib/Host.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '73', column '23').
      Open

                  throw new \Exception($msg);
      Severity: Minor
      Found in phplib/Host.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Avoid unused parameters such as '$from'.
      Open

              $from = null,
      Severity: Minor
      Found in phplib/GraphiteGraph.php by phpmd

      UnusedFormalParameter

      Since: 0.2

      Avoid passing parameters to methods or constructors and then not using those parameters.

      Example

      class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

      Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

      A closing tag is not permitted at the end of a PHP file
      Open

      ?>
      Severity: Minor
      Found in htdocs/index.php by phpcodesniffer
      Severity
      Category
      Status
      Source
      Language