Sign upLogin

mseemann/angular2-mdl

View on GitHub
Star
projects/core/src/lib/dialog/mdl-dialog-host.component.ts

Summary

Maintainability
A
3 hrs
Test Coverage
A
100%

Function show has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  show(): void {
    this.visible = true;
    // give the dialogs time to draw so that a focus can be set
    setTimeout(() => {
      this.internalDialogRef.visible();
Severity: Major
Found in projects/core/src/lib/dialog/mdl-dialog-host.component.ts - About 2 hrs to fix

    Function show has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      show(): void {
    this.visible = true;
    // give the dialogs time to draw so that a focus can be set
    setTimeout(() => {
      this.internalDialogRef.visible();
    Severity: Minor
    Found in projects/core/src/lib/dialog/mdl-dialog-host.component.ts - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status