msimerson/Haraka

View on GitHub

Showing 655 of 655 total issues

Avoid too many return statements within this function.
Open

            return require(path.join(path.dirname(this.plugin_path), module));
Severity: Major
Found in plugins.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                    return this.result(null, ((verified) ? 'pass' : 'fail'));
    Severity: Major
    Found in dkim.js - About 30 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              else {
                  new_ipv4_hosts[i] = [ipaddr.IPv4.parse(host[0]), parseInt(host[1] || 32)];
              }
      Severity: Minor
      Found in connection.js and 1 other location - About 30 mins to fix
      connection.js on lines 40..42

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid too many return statements within this function.
      Open

                          return this.result('invalid algorithm', 'invalid');
      Severity: Major
      Found in dkim.js - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (dom.toLowerCase() !== this.fields.d.toLowerCase()) {
                        return this.result('i/d selector domain mismatch', 'invalid')
                    }
        Severity: Minor
        Found in dkim.js and 1 other location - About 30 mins to fix
        dkim.js on lines 366..368

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this function.
        Open

                if (!this.fields.bh) return this.result('body hash missing', 'invalid');
        Severity: Major
        Found in dkim.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                                      return this.result('inappropriate hash algorithm', 'invalid');
          Severity: Major
          Found in dkim.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return this.result('missing algorithm', 'invalid');
            Severity: Major
            Found in dkim.js - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (net.isIPv6(host[0])) {
                          new_ipv6_hosts[i] = [ipaddr.IPv6.parse(host[0]), parseInt(host[1] || 64)];
                      }
              Severity: Minor
              Found in connection.js and 1 other location - About 30 mins to fix
              connection.js on lines 43..45

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Avoid too many return statements within this function.
              Open

                              return this.result('i/d selector domain mismatch', 'invalid')
              Severity: Major
              Found in dkim.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return this.result('signed headers missing', 'invalid');
                Severity: Major
                Found in dkim.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return this.result('unknown query method', 'invalid');
                  Severity: Major
                  Found in dkim.js - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if (!this.cfg.bigco) {
                            connection.results.add(this, {err: 'big_co(config missing)'});
                            return next();
                        }
                    Severity: Minor
                    Found in plugins/helo.checks.js and 1 other location - About 30 mins to fix
                    plugins/relay.js on lines 139..142

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Avoid too many return statements within this function.
                    Open

                                    return this.result('creation date is invalid or in the future', 'invalid')
                    Severity: Major
                    Found in dkim.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                              return this.result('inappropriate key type', 'invalid');
                      Severity: Major
                      Found in dkim.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                if (!this.fields.b)  return this.result('signature missing', 'invalid');
                        Severity: Major
                        Found in dkim.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                          return this.result('invalid expiration date', 'invalid');
                          Severity: Major
                          Found in dkim.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                            return this.result('from field not signed', 'invalid');
                            Severity: Major
                            Found in dkim.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                                  return this.result('inapplicable key', 'invalid');
                              Severity: Major
                              Found in dkim.js - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                                if (!this.dns_fields.p) return this.result('key revoked', 'invalid');
                                Severity: Major
                                Found in dkim.js - About 30 mins to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language