Sign upLogin

msimerson/maxmind-geolite-mirror

View on GitHub
Star

Showing 3 of 3 total issues

Function isRemoteNewer has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function isRemoteNewer (dest, httpOpts, done) {

    if (!fs.existsSync(dest)) {
        // con.log(`${dest} does not exist`);
        return done(true);
Severity: Minor
Found in lib/mm-geolite-mirror.js - About 1 hr to fix

    Function doOne has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function doOne (item, done) {

    if (!config.license_key && !process.env.MM_TESTING) {
        return done(`missing license_key in ${path.resolve(__dirname, 'config.js')}!`);
    }
    Severity: Minor
    Found in lib/mm-geolite-mirror.js - About 1 hr to fix

      Function isRemoteNewer has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      function isRemoteNewer (dest, httpOpts, done) {

    if (!fs.existsSync(dest)) {
        // con.log(`${dest} does not exist`);
        return done(true);
      Severity: Minor
      Found in lib/mm-geolite-mirror.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language