Sign upLogin

mskog/broad

View on GitHub
Star
app/models/movie.rb

Summary

Maintainability
A
3 hrs
Test Coverage
B
85%

Class Movie has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

class Movie < ApplicationRecord
  include Base64Images
  include PgSearch::Model

  multisearchable against: [:title]
Severity: Minor
Found in app/models/movie.rb - About 2 hrs to fix

    Method fetch_release_dates has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def fetch_release_dates
    qualities = ["Unknown", "Digital HD", "Blu-ray", "4K UHD"]
    struct = Struct.new(:release_date, :release_type, :quality)

    release_dates.delete_all
    Severity: Minor
    Found in app/models/movie.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status