Sign upLogin

mskog/stew

View on GitHub
Star

Showing 2 of 2 total issues

Class App has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

    class App
      def initialize(response, id)
        @document = Nokogiri::HTML(response)
        @id = id
      end
Severity: Minor
Found in lib/stew/store/app.rb - About 2 hrs to fix

    Method steam_id_from_matches has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def steam_id_from_matches(data, matches)
        if matches.nil?
          return @client.vanity_url_to_steam_id(data) unless data.include?('/')
        elsif matches[1] != 'profiles'
          return @client.vanity_url_to_steam_id(data)
    Severity: Minor
    Found in lib/stew/community/steam_id_resolver.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language