Sign upLogin

mtortonesi/ruby-mhl

View on GitHub
Star

Showing 41 of 41 total issues

Method solve has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
Open

    def solve(func, params={})

      # MPSO starts with a single swarm in 2008 paper
      # swarms = Array.new(@num_swarms) do |index|
      swarms = Array.new(@num_swarms) do |index|
Severity: Minor
Found in lib/mhl/multiswarm_qpso_solver.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method solve has 155 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def solve(func, params={})

      # MPSO starts with a single swarm in 2008 paper
      # swarms = Array.new(@num_swarms) do |index|
      swarms = Array.new(@num_swarms) do |index|
Severity: Major
Found in lib/mhl/multiswarm_qpso_solver.rb - About 6 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          def repair_chromosome(g)
        g.each_index do |i|
          if g[i] < @constraints[i][:from]
            range = "[#{@constraints[i][:from]},#{@constraints[i][:to]}]"
            @logger.debug "repairing g[#{i}] #{g[i]} to fit within #{range}" if @logger
    Severity: Major
    Found in lib/mhl/real_vector_genotype_space.rb and 1 other location - About 3 hrs to fix
    lib/mhl/integer_vector_genotype_space.rb on lines 122..134

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 130.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          def repair_chromosome(g)
        g.each_index do |i|
          if g[i] < @constraints[i][:from]
            range = "[#{@constraints[i][:from]},#{@constraints[i][:to]}]"
            @logger.debug "repairing g[#{i}] #{g[i]} to fit within #{range}" if @logger
    Severity: Major
    Found in lib/mhl/integer_vector_genotype_space.rb and 1 other location - About 3 hrs to fix
    lib/mhl/real_vector_genotype_space.rb on lines 124..136

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 130.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method solve has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def solve(func, params={})

      # initialize particle positions
      init_pos = if @start_positions
        # start positions have the highest priority
    Severity: Major
    Found in lib/mhl/particle_swarm_optimization_solver.rb - About 2 hrs to fix

      Method initialize has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def initialize(opts)
      @population_size = opts[:population_size].to_i
      unless @population_size and @population_size.even?
        raise ArgumentError, 'Even population size required!'
      end
      Severity: Major
      Found in lib/mhl/genetic_algorithm_solver.rb - About 2 hrs to fix

        Method solve has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            def solve(func, params={})

      # initialize particle positions
      init_pos = if @start_positions
        # start positions have the highest priority
        Severity: Minor
        Found in lib/mhl/particle_swarm_optimization_solver.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method initialize has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            def initialize(size:, initial_positions:, initial_velocities:,
                   charged_to_neutral_ratio: nil, alpha: nil, c1: nil, c2: nil,
                   chi: nil, constraints: nil, logger: nil)
      @size = size
        Severity: Minor
        Found in lib/mhl/charged_swarm.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method repair_chromosome has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

              def repair_chromosome(g)
        g.each_index do |i|
          if g[i] < @constraints[i][:from]
            range = "[#{@constraints[i][:from]},#{@constraints[i][:to]}]"
            @logger.debug "repairing g[#{i}] #{g[i]} to fit within #{range}" if @logger
        Severity: Minor
        Found in lib/mhl/real_vector_genotype_space.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method repair_chromosome has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

              def repair_chromosome(g)
        g.each_index do |i|
          if g[i] < @constraints[i][:from]
            range = "[#{@constraints[i][:from]},#{@constraints[i][:to]}]"
            @logger.debug "repairing g[#{i}] #{g[i]} to fit within #{range}" if @logger
        Severity: Minor
        Found in lib/mhl/integer_vector_genotype_space.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method solve has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def solve(func, params={})
      # initialize particle positions
      init_pos = if @start_positions
        # start positions have the highest priority
        @start_positions
        Severity: Minor
        Found in lib/mhl/quantum_particle_swarm_optimization_solver.rb - About 1 hr to fix

          Method solve has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def solve(func, params={})
      # setup population
      if @start_population.nil?
        population = Array.new(@population_size) do
          # generate random genotype according to the chromosome type
          Severity: Minor
          Found in lib/mhl/genetic_algorithm_solver.rb - About 1 hr to fix

            Method call has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                def call(solver, best)
      @history << best

      if @history.size > @generations
        # calculate improvement ratio
            Severity: Minor
            Found in lib/mhl/rechenberg_controller.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method initialize has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                def initialize(opts)
      @population_size = opts[:population_size].to_i
      unless @population_size and @population_size.even?
        raise ArgumentError, 'Even population size required!'
      end
            Severity: Minor
            Found in lib/mhl/genetic_algorithm_solver.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method solve has 38 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def solve(func, params={})

      if params[:concurrent]
        @concurrent = true
      else
            Severity: Minor
            Found in lib/mhl/grey_wolf_solver.rb - About 1 hr to fix

              Method solve has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  def solve(func, params={})
      # initialize particle positions
      init_pos = if @start_positions
        # start positions have the highest priority
        @start_positions
              Severity: Minor
              Found in lib/mhl/quantum_particle_swarm_optimization_solver.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method solve has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  def solve(func, params={})

      if params[:concurrent]
        @concurrent = true
      else
              Severity: Minor
              Found in lib/mhl/grey_wolf_solver.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method initialize has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  def initialize(size:, initial_positions:, initial_velocities:,
                   charged_to_neutral_ratio: nil, alpha: nil, c1: nil, c2: nil,
                   chi: nil, constraints: nil, logger: nil)
      @size = size
              Severity: Minor
              Found in lib/mhl/charged_swarm.rb - About 1 hr to fix

                Method solve has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                    def solve(func, params={})
      # setup population
      if @start_population.nil?
        population = Array.new(@population_size) do
          # generate random genotype according to the chromosome type
                Severity: Minor
                Found in lib/mhl/genetic_algorithm_solver.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    def reproduce_from(p1, p2, mutation_rv, recombination_rv)
      # make copies of p1 and p2
      # (we're only interested in the :genotype key)
      c1 = { genotype: p1[:genotype].dup }
      c2 = { genotype: p2[:genotype].dup }
                Severity: Major
                Found in lib/mhl/integer_vector_genotype_space.rb and 1 other location - About 1 hr to fix
                lib/mhl/real_vector_genotype_space.rb on lines 44..62

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 50.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language