Sign upLogin

mtortonesi/symian

View on GitHub
Star
lib/symian/work_shift.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method initialize has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def initialize(type, params={})
      case type
        when :predefined
          # get workshift id
          raise ArgumentError unless params[:id]
Severity: Minor
Found in lib/symian/work_shift.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method secs_to_end_of_shift has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def secs_to_end_of_shift(time)
      raise 'secs_to_end_of_shift called for unavailable operator' unless active_at?(time)
      return Infinity if @type == :all_day_long

      t = time.utc.seconds_since_midnight.round
Severity: Minor
Found in lib/symian/work_shift.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method secs_to_begin_of_shift has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def secs_to_begin_of_shift(time)
      raise 'secs_to_begin_of_shift called for available operator' if active_at?(time)

      t = time.utc.seconds_since_midnight.round
      res = if @overnight
Severity: Minor
Found in lib/symian/work_shift.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status