multunus/react-native-boilerplate

View on GitHub

Showing 26 of 26 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        <TouchableHighlight onPress={onPressRegister}>
          <View style={styles.button}>
            <Text style={styles.text}>
              {buttonText}
            </Text>
Severity: Minor
Found in src/screens/auth/components/registerComponent.ios.js and 1 other location - About 55 mins to fix
src/screens/auth/components/registerComponent.android.js on lines 19..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        <TouchableNativeFeedback background={TouchableNativeFeedback.SelectableBackground()}
          onPress={onPressRegister}
        >
        <View style={styles.button}>
          <Text style={styles.text}>
Severity: Minor
Found in src/screens/auth/components/registerComponent.android.js and 1 other location - About 55 mins to fix
src/screens/auth/components/registerComponent.ios.js on lines 19..25

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function stateTransformer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  const stateTransformer = (state) => {
    const logState = {};
    for (let key in state) {
      if (state.hasOwnProperty(key) && Iterable.isIterable(state[key])) {
        logState[key] = state[key].toJS();
Severity: Minor
Found in src/store/store.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Definition for rule 'react/jsx-sort-prop-types' was not found
Open

import React, { ProgressBarAndroid, StyleSheet, Text, TouchableNativeFeedback, View } from 'react-native';

For more information visit Source: http://eslint.org/docs/rules/

Definition for rule 'react/jsx-sort-prop-types' was not found
Open

import createSagaMiddleware from 'redux-saga';
Severity: Minor
Found in src/modules/sagas.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

'buttonText' is missing in props validation
Open

const RegisterComponent = ({ onRegister, isRegistering, buttonText }) => {

For more information visit Source: http://eslint.org/docs/rules/

Definition for rule 'react/jsx-sort-prop-types' was not found
Open

import { types } from './constants';
Severity: Minor
Found in src/modules/auth/actions.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

'isRegistering' is missing in props validation
Open

const RegisterComponent = ({ onRegister, isRegistering, buttonText }) => {

For more information visit Source: http://eslint.org/docs/rules/

Definition for rule 'react/jsx-sort-prop-types' was not found
Open

import React, { Component, PropTypes } from 'react-native';

For more information visit Source: http://eslint.org/docs/rules/

Definition for rule 'react/jsx-sort-prop-types' was not found
Open

import { AppRegistry } from 'react-native';
Severity: Minor
Found in index.ios.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Definition for rule 'react/jsx-sort-prop-types' was not found
Open

export const types = {
Severity: Minor
Found in src/modules/auth/constants.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Definition for rule 'react/jsx-sort-prop-types' was not found
Open

import { call, put, take } from 'redux-saga/effects';
Severity: Minor
Found in src/modules/auth/saga.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

'onRegister' is missing in props validation
Open

const RegisterComponent = ({ onRegister, isRegistering, buttonText }) => {

For more information visit Source: http://eslint.org/docs/rules/

Definition for rule 'react/jsx-sort-prop-types' was not found
Open

const styles = {

For more information visit Source: http://eslint.org/docs/rules/

Definition for rule 'react/jsx-sort-prop-types' was not found
Open

import axios from 'axios';
Severity: Minor
Found in src/services/api/api.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

'isRegistering' is missing in props validation
Open

const RegisterComponent = ({ onRegister, isRegistering, buttonText }) => {

For more information visit Source: http://eslint.org/docs/rules/

'buttonText' is missing in props validation
Open

const RegisterComponent = ({ onRegister, isRegistering, buttonText }) => {

For more information visit Source: http://eslint.org/docs/rules/

Definition for rule 'react/jsx-sort-prop-types' was not found
Open

import 'es6-symbol/implement'; // Polyfill for ES6 symbol
Severity: Minor
Found in src/store/store.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Definition for rule 'react/jsx-sort-prop-types' was not found
Open

import { AppRegistry } from 'react-native';
Severity: Minor
Found in index.android.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Definition for rule 'react/jsx-sort-prop-types' was not found
Open

import React, { Component } from 'react-native';
Severity: Minor
Found in src/app.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Severity
Category
Status
Source
Language