Sign upLogin

mumuki/mumuki-gobstones-runner

View on GitHub
Star

Showing 7 of 7 total issues

Class GobstonesExplainer has 39 methods (exceeds 20 allowed). Consider refactoring.
Open

  class GobstonesExplainer < Mumukit::Explainer
    def explain_program_has_a_name(submission, result)
      if identifier_instead_of_brace? result
        (submission.match malformed_program_header_with_name).try do |it|
          { name: it[1] }
Severity: Minor
Found in lib/feedback_hook.rb - About 5 hrs to fix

    Method metadata has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def metadata
    {
      language: {
        name: 'gobstones',
        icon: {type: 'devicon', name: 'gobstones'},
    Severity: Minor
    Found in lib/metadata_hook.rb - About 1 hr to fix

      Method check_final_board has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def check_final_board(output, expected)
      status = output[:status]
      result = output[:result]

      return if is_expected_timeout(result)
      Severity: Minor
      Found in lib/checker.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

            return "wrong_argument_type" if has_wrong_argument_type? code
      Severity: Major
      Found in lib/checker.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return "wrong_arguments_quantity" if code.include? 'arity-mismatch'
        Severity: Major
        Found in lib/checker.rb - About 30 mins to fix

          Method parse_example has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def parse_example(options, example)
      return example unless options[:subject]

      return_value = example[:postconditions][:return]
      if return_value
          Severity: Minor
          Found in lib/gobstones/batch_parser.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method convert_known_reason_code has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def convert_known_reason_code(code)
      return "no_stones" if code == 'cannot-remove-stone'
      return "out_of_board" if code == 'cannot-move-to'
      return "unassigned_variable" if code == 'undefined-variable'
      return "boom_called" if code == 'boom-called'
          Severity: Minor
          Found in lib/checker.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language