Sign upLogin

mumuki/mumuki-puzzle-runner

View on GitHub
Star

Showing 7 of 7 total issues

MuzzleCanvas has 38 functions (exceeds 20 allowed). Consider refactoring.
Open

class MuzzleCanvas {

  // =============
  // Global canvas
  // =============
Severity: Minor
Found in lib/public/js/muzzle.js - About 5 hrs to fix

    File muzzle.js has 338 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * @typedef {number[]} Point
 */

/**
    Severity: Minor
    Found in lib/public/js/muzzle.js - About 4 hrs to fix

      Function match has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        async match(leftUrls, rightUrls, {leftOddUrls = [], rightOddUrls = [], rightAspectRatio = this.effectiveAspectRatio} = {}) {
    const rightWidthRatio = rightAspectRatio / this.effectiveAspectRatio;

    this._config('simple', false);
    this._config('shuffler', Muzzle.Shuffler.columns);
      Severity: Major
      Found in lib/public/js/muzzle.js - About 2 hrs to fix

        Method metadata has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def metadata
    {
      language: {
        name: 'muzzle',
        version: PuzzleVersionHook::VERSION,
        Severity: Minor
        Found in lib/metadata_hook.rb - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              leftOddUrls.forEach((it, i) =>
      pushLeftTemplate(i + leftUrls.length, it, {
        id: `lo${i}`,
        odd: true
      })
          Severity: Minor
          Found in lib/public/js/muzzle.js and 1 other location - About 40 mins to fix
          lib/public/js/muzzle.js on lines 421..426

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              rightOddUrls.forEach((it, i) =>
      pushRightTemplate(i + rightUrls.length, it, {
        id: `ro${i}`,
        odd: true
      })
          Severity: Minor
          Found in lib/public/js/muzzle.js and 1 other location - About 40 mins to fix
          lib/public/js/muzzle.js on lines 415..420

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method run! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def run!(req)
    if req.client_result
      ['', (req.client_result['status'].passed? ? :passed : :failed)]
    elsif !req.expected || positions_relatively_equal(req.expected, req.actual)
      ['', :passed]
          Severity: Minor
          Found in lib/test_hook.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language