Sign upLogin

muneebalam/scrapenhl2

View on GitHub
Star
scrapenhl2/scrape/general_helpers.py

Summary

Maintainability
B
4 hrs
Test Coverage

File general_helpers.py has 306 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""
This module contains general helper methods. None of these methods have dependencies on other scrapenhl2 modules.
"""

import functools
Severity: Minor
Found in scrapenhl2/scrape/general_helpers.py - About 3 hrs to fix

    Function try_url_n_times has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    def try_url_n_times(url, timeout=5, n=5):
    """
    A helper method that tries to access given url up to five times, returning the page.

    :param url: str, the url to access
    Severity: Minor
    Found in scrapenhl2/scrape/general_helpers.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status