Sign upLogin

muneebalam/scrapenhl2

View on GitHub
Star
scrapenhl2/twitterbot/gamebot.py

Summary

Maintainability
F
4 days
Test Coverage

Function on_success has a Cognitive Complexity of 72 (exceeds 5 allowed). Consider refactoring.
Open

    def on_success(self, data):
        if 'text' in data:
            print(data['text'])

            if r'https://t.co/' in data['text']:
Severity: Minor
Found in scrapenhl2/twitterbot/gamebot.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File gamebot.py has 257 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from twython import Twython
from twython import TwythonStreamer
import re
import time
import os
Severity: Minor
Found in scrapenhl2/twitterbot/gamebot.py - About 2 hrs to fix

    Function tweet_game_images has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def tweet_game_images(h2hfile, tlfile, hname, rname, status, tweetdata):
    Severity: Minor
    Found in scrapenhl2/twitterbot/gamebot.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                                  if team_info.team_as_id(part) is not None:
                                teams.append(part)
                    if len(teams) == 0:
      Severity: Major
      Found in scrapenhl2/twitterbot/gamebot.py - About 45 mins to fix

        Avoid too many return statements within this function.
        Open

                                    return
        Severity: Major
        Found in scrapenhl2/twitterbot/gamebot.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                                  return
          Severity: Major
          Found in scrapenhl2/twitterbot/gamebot.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                                    return
            Severity: Major
            Found in scrapenhl2/twitterbot/gamebot.py - About 30 mins to fix

              Function player_cf_graphs has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              def player_cf_graphs(tweetdata):
    """
    If tweet fits
    :param tweetdata:
    :return:
              Severity: Minor
              Found in scrapenhl2/twitterbot/gamebot.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              def tweet_player_gf_graph(file, pname, tweetdata):
    """

    :param file:
    :param name:
              Severity: Major
              Found in scrapenhl2/twitterbot/gamebot.py and 1 other location - About 4 hrs to fix
              scrapenhl2/twitterbot/gamebot.py on lines 63..76

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 85.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              def tweet_player_cf_graph(file, pname, tweetdata):
    """

    :param file:
    :param name:
              Severity: Major
              Found in scrapenhl2/twitterbot/gamebot.py and 1 other location - About 4 hrs to fix
              scrapenhl2/twitterbot/gamebot.py on lines 79..92

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 85.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  with open(tlfile, 'rb') as photo:
        response = twitter.upload_media(media=photo)
        twitter.update_status(
            status='@{3:s} TL: {0:s} @ {1:s} ({2:s}){4:s}'.format(rname, hname, status,
                                                                  tweetdata['user']['screen_name'],
              Severity: Major
              Found in scrapenhl2/twitterbot/gamebot.py and 1 other location - About 4 hrs to fix
              scrapenhl2/twitterbot/gamebot.py on lines 116..122

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 77.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  with open(h2hfile, 'rb') as photo:
        response = twitter.upload_media(media=photo)
        twitter.update_status(
            status='@{3:s} H2H: {0:s} @ {1:s} ({2:s}){4:s}'.format(rname, hname, status,
                                                                   tweetdata['user']['screen_name'], suffix),
              Severity: Major
              Found in scrapenhl2/twitterbot/gamebot.py and 1 other location - About 4 hrs to fix
              scrapenhl2/twitterbot/gamebot.py on lines 123..130

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 77.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              if not SILENT:
    twitter.update_status(status="I'm active now ({0:s} ET)".format(
        datetime.datetime.now().strftime('%Y-%m-%d %-H:%M ET')))
              Severity: Minor
              Found in scrapenhl2/twitterbot/gamebot.py and 1 other location - About 55 mins to fix
              scrapenhl2/twitterbot/gamebot.py on lines 319..321

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 37.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if not SILENT:
        twitter.update_status(status="I'm turning off now ({0:s})".format(
            datetime.datetime.now().strftime('%Y-%m-%d %-H:%M ET')))
              Severity: Minor
              Found in scrapenhl2/twitterbot/gamebot.py and 1 other location - About 55 mins to fix
              scrapenhl2/twitterbot/gamebot.py on lines 46..48

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 37.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status