Sign upLogin

murdercode/laravel-shortcode-plus

View on GitHub
Star

Showing 13 of 13 total issues

Function register has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    public function register($shortcode): string
    {
        if (! class_exists('\Outl1ne\NovaMediaHub\Models\Media')) {
            return '';
        }
Severity: Minor
Found in src/Shortcodes/PhotoShortcode.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method register has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function register($shortcode): string
    {
        if (! class_exists('\Outl1ne\NovaMediaHub\Models\Media')) {
            return '';
        }
Severity: Major
Found in src/Shortcodes/PhotoShortcode.php - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                            if ($rel === 'dofollow') {
                            if (preg_match('/rel="noopener"/', $matches[0])) {
                                return str_replace('rel="noopener"', 'rel="'.$rel.'"', $matches[0]);
                            } elseif (! preg_match('/rel="/', $matches[0])) {
                                return str_replace('<a '.$matches[1], '<a '.$matches[1].' rel="'.$rel.'"', $matches[0]);
    Severity: Major
    Found in src/Helpers/Sanitizer.php and 1 other location - About 1 hr to fix
    src/Helpers/Sanitizer.php on lines 49..55

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 116.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                            } else {
                            if (preg_match('/rel="noopener"/', $matches[0])) {
                                return str_replace('rel="noopener"', 'rel="'.$rel.' noopener"', $matches[0]);
                            } elseif (! preg_match('/rel="/', $matches[0])) {
                                return str_replace('<a '.$matches[1], '<a '.$matches[1].' rel="'.$rel.' noopener"', $matches[0]);
    Severity: Major
    Found in src/Helpers/Sanitizer.php and 1 other location - About 1 hr to fix
    src/Helpers/Sanitizer.php on lines 43..55

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 116.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method parse has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function parse(string $content): string
    {

        return preg_replace_callback(
            '/\[image id="(\d+)"(?:\scaption="(.*?)")?(?:(.*?))\]/',
    Severity: Minor
    Found in src/Parsers/Image.php - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          private static function getOembed(string $url): ?string
    {
        curl_setopt_array($curl = curl_init(), [
            CURLOPT_URL => "https://publish.twitter.com/oembed?url=$url&omit_script=1",
            CURLOPT_RETURNTRANSFER => true,
      Severity: Minor
      Found in src/Shortcodes/TwitterShortcode.php and 1 other location - About 55 mins to fix
      src/AltShortcodes/TwitterShortcode.php on lines 28..38

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 98.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          private static function getOembed(string $url): ?string
    {
        curl_setopt_array($curl = curl_init(), [
            CURLOPT_URL => "https://publish.twitter.com/oembed?url=$url&omit_script=1",
            CURLOPT_RETURNTRANSFER => true,
      Severity: Minor
      Found in src/AltShortcodes/TwitterShortcode.php and 1 other location - About 55 mins to fix
      src/Shortcodes/TwitterShortcode.php on lines 28..38

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 98.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          private static function getOembed(string $url): ?string
    {
        curl_setopt_array($curl = curl_init(), [
            CURLOPT_URL => "https://www.tiktok.com/oembed?url=$url",
            CURLOPT_RETURNTRANSFER => true,
      Severity: Minor
      Found in src/Shortcodes/TikTokShortcode.php and 1 other location - About 50 mins to fix
      src/AltShortcodes/TikTokShortcode.php on lines 28..38

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 97.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          private static function getOembed(string $url): ?string
    {
        curl_setopt_array($curl = curl_init(), [
            CURLOPT_URL => "https://www.tiktok.com/oembed?url=$url",
            CURLOPT_RETURNTRANSFER => true,
      Severity: Minor
      Found in src/AltShortcodes/TikTokShortcode.php and 1 other location - About 50 mins to fix
      src/Shortcodes/TikTokShortcode.php on lines 28..38

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 97.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function generateTree has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected static function generateTree($headings)
    {
        $headlines = [];

        foreach ($headings as $heading) {
      Severity: Minor
      Found in src/Parsers/Index.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                      return view('shortcode-plus::new-gallery', compact('images', 'title'))->render();
      Severity: Major
      Found in src/Shortcodes/PhotoShortcode.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return '';
        Severity: Major
        Found in src/Shortcodes/PhotoShortcode.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return view('shortcode-plus::media', compact('path', 'align', 'maxWidth', 'link', 'shape', 'didascalia', 'credits', 'alt', 'title', 'width', 'height'))->render();
          Severity: Major
          Found in src/Shortcodes/PhotoShortcode.php - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language