murdercode/laravel-shortcode-plus

View on GitHub

Showing 7 of 13 total issues

Function register has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    public function register($shortcode): string
    {
        if (! class_exists('\Outl1ne\NovaMediaHub\Models\Media')) {
            return '';
        }
Severity: Minor
Found in src/Shortcodes/PhotoShortcode.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method register has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function register($shortcode): string
    {
        if (! class_exists('\Outl1ne\NovaMediaHub\Models\Media')) {
            return '';
        }
Severity: Major
Found in src/Shortcodes/PhotoShortcode.php - About 2 hrs to fix

    Method parse has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function parse(string $content): string
        {
    
            return preg_replace_callback(
                '/\[image id="(\d+)"(?:\scaption="(.*?)")?(?:(.*?))\]/',
    Severity: Minor
    Found in src/Parsers/Image.php - About 1 hr to fix

      Function generateTree has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected static function generateTree($headings)
          {
              $headlines = [];
      
              foreach ($headings as $heading) {
      Severity: Minor
      Found in src/Parsers/Index.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                      return view('shortcode-plus::new-gallery', compact('images', 'title'))->render();
      Severity: Major
      Found in src/Shortcodes/PhotoShortcode.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return '';
        Severity: Major
        Found in src/Shortcodes/PhotoShortcode.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return view('shortcode-plus::media', compact('path', 'align', 'maxWidth', 'link', 'shape', 'didascalia', 'credits', 'alt', 'title', 'width', 'height'))->render();
          Severity: Major
          Found in src/Shortcodes/PhotoShortcode.php - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language