Sign upLogin

museways/economy

View on GitHub
Star

Showing 9 of 9 total issues

Method define_setter has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def define_setter(attribute, currency_column, currency_attribute, condition_attribute)
      concern.class_eval do
        define_method "#{attribute}=" do |value|
          if send(condition_attribute)
            case value
Severity: Minor
Found in lib/economy/builder.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Money has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Money
    include Comparable

    attr_reader :amount, :currency, :record, :renderer
Severity: Minor
Found in lib/economy/money.rb - About 2 hrs to fix

    Method define_helpers has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        def define_helpers(attribute, condition_attribute, options)
      concern.class_eval do
        define_method "#{attribute}_came_from_user?" do
          true
        end
    Severity: Minor
    Found in lib/economy/builder.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method define_getter has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def define_getter(attribute, currency_attribute, condition_attribute, renderer)
      concern.class_eval do
        define_method attribute do
          if send(condition_attribute)
            value = read_attribute(attribute)
    Severity: Minor
    Found in lib/economy/builder.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method call has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def call
        ids = Economy.currencies.map(&:iso_code).permutation(2).map(&:join).join(',')
        uri = URI('https://query.yahooapis.com/v1/public/yql')
        uri.query = URI.encode_www_form(
          q: "select * from yahoo.finance.xchange where pair in ('#{ids}')",
    Severity: Minor
    Found in lib/economy/rates/open_exchange_rates.rb - About 1 hr to fix

      Method define has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def define(*args)
      options = args.extract_options!
      if args.last.is_a?(Proc)
        renderer = args.pop
      end
      Severity: Minor
      Found in lib/economy/builder.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method call has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def call
        ids = Economy.currencies.map(&:iso_code).permutation(2).map(&:join).join(',')
        uri = URI('https://query.yahooapis.com/v1/public/yql')
        uri.query = URI.encode_www_form(
          q: "select * from yahoo.finance.xchange where pair in ('#{ids}')",
      Severity: Minor
      Found in lib/economy/rates/open_exchange_rates.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def /(value)
      case value
      when Money
        amount / value.exchange_to(currency).amount
      when Numeric
      Severity: Minor
      Found in lib/economy/money.rb and 1 other location - About 20 mins to fix
      lib/economy/money.rb on lines 86..93

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def *(value)
      case value
      when Money
        amount * value.exchange_to(currency).amount
      when Numeric
      Severity: Minor
      Found in lib/economy/money.rb and 1 other location - About 20 mins to fix
      lib/economy/money.rb on lines 97..104

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language