muthash/Weconnect-v1

View on GitHub
app/auth/views.py

Summary

Maintainability
A
0 mins
Test Coverage

Function put has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Invalid

    def put(self):
        """Endpoint to change a user password"""
        if self.validate_json():
            return self.validate_json()

Severity: Minor
Found in app/auth/views.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Invalid

        return jsonify(response), 201
Severity: Major
Found in app/auth/views.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Invalid

                return jsonify(response), 409
    Severity: Major
    Found in app/auth/views.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Invalid

              return jsonify(response), 201
      Severity: Major
      Found in app/auth/views.py - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status