Sign upLogin

mvc5/mvc5

View on GitHub
Star

Showing 1,086 of 1,086 total issues

Similar blocks of code found in 6 locations. Consider refactoring.
Open

<?php
/**
 *
 */
Severity: Major
Found in src/Http/Error/ServerError.php and 5 other locations - About 40 mins to fix
src/Http/Error/BadRequest.php on lines 1..27
src/Http/Error/Forbidden.php on lines 1..27
src/Http/Error/MethodNotAllowed.php on lines 1..27
src/Http/Error/NotFound.php on lines 1..27
src/Http/Error/Unauthorized.php on lines 1..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

<?php
/**
 *
 */
Severity: Major
Found in src/Http/Error/MethodNotAllowed.php and 5 other locations - About 40 mins to fix
src/Http/Error/BadRequest.php on lines 1..27
src/Http/Error/Forbidden.php on lines 1..27
src/Http/Error/NotFound.php on lines 1..27
src/Http/Error/ServerError.php on lines 1..27
src/Http/Error/Unauthorized.php on lines 1..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

<?php
/**
 *
 */
Severity: Major
Found in src/Http/Error/NotFound.php and 5 other locations - About 40 mins to fix
src/Http/Error/BadRequest.php on lines 1..27
src/Http/Error/Forbidden.php on lines 1..27
src/Http/Error/MethodNotAllowed.php on lines 1..27
src/Http/Error/ServerError.php on lines 1..27
src/Http/Error/Unauthorized.php on lines 1..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

<?php
/**
 *
 */
Severity: Major
Found in src/Http/Error/BadRequest.php and 5 other locations - About 40 mins to fix
src/Http/Error/Forbidden.php on lines 1..27
src/Http/Error/MethodNotAllowed.php on lines 1..27
src/Http/Error/NotFound.php on lines 1..27
src/Http/Error/ServerError.php on lines 1..27
src/Http/Error/Unauthorized.php on lines 1..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method match has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    protected function match(Route $route, Request $request, string $path, int $offset, callable $next)
Severity: Minor
Found in src/Route/Match/Path.php - About 35 mins to fix

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        function __construct(string $name = null, array $args = [], array $calls = [], string $param = null, bool $merge = false)
    Severity: Minor
    Found in src/Plugin/Plugin.php - About 35 mins to fix

      Method repeat has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          protected function repeat($plugin, string $method, array $name = [], array $args = [], callable $callback = null)
      Severity: Minor
      Found in src/Resolver/Service.php - About 35 mins to fix

        Method iterate has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            protected function iterate($result, $event, Iterator $iterator, array $args, callable $callback = null)
        Severity: Minor
        Found in src/Event/Generator.php - About 35 mins to fix

          Method compile has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              static function compile(string $scheme = null, string $authority = null, string $path = null, string $query = null, string $fragment = null) : string
          Severity: Minor
          Found in src/Url/Assemble.php - About 35 mins to fix

            Avoid too many return statements within this method.
            Open

                        return $this->resolve($this->param($gem->name()), $args);
            Severity: Major
            Found in src/Resolver/Resolver.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return $this->filterable($gem, $this->vars($args, $gem->args()));
              Severity: Major
              Found in src/Resolver/Resolver.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return $this->resolve($plugin, $args);
                Severity: Major
                Found in src/Resolver/Resolver.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return fn(...$argv) => $this->resolve($this->call(
                $this->resolve($gem->config()), $this->vars($this->variadic($argv), $gem->args())
            ));
                  Severity: Major
                  Found in src/Resolver/Resolver.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return $this->configured($gem->name());
                    Severity: Major
                    Found in src/Resolver/Resolver.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                      return $this->resolve($gem->plugin(), $args);
                      Severity: Major
                      Found in src/Resolver/Resolver.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return clone $this->resolve($gem->config(), $args);
                        Severity: Major
                        Found in src/Resolver/Resolver.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                      return $this->call($this->resolve($gem->config()), $this->vars($args, $gem->args()));
                          Severity: Major
                          Found in src/Resolver/Resolver.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                        return $this->scoped($gem->closure(), $gem->scoped());
                            Severity: Major
                            Found in src/Resolver/Resolver.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                      return $next($route, $request->with(CONTROLLER, $controller));
                              Severity: Major
                              Found in src/Route/Match/Controller.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                            return $this->args($gem->config());
                                Severity: Major
                                Found in src/Resolver/Resolver.php - About 30 mins to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language