Sign upLogin

mvidner/ruby-dbus

View on GitHub
Star
lib/dbus/auth.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method next_state has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def next_state(received_words)
        msg = received_words

        case @state
        when :WaitingForData
Severity: Major
Found in lib/dbus/auth.rb - About 2 hrs to fix

    Method read_line has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def read_line
        # TODO: probably can simply call @socket.readline
        data = ""
        crlf = "\r\n"
        left = 1024 # 1024 byte, no idea if it's ever getting bigger
    Severity: Minor
    Found in lib/dbus/auth.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method call has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def call(challenge)
        if challenge.nil?
          require "etc"
          # number of retries we have for auth
          @retries = 1
    Severity: Minor
    Found in lib/dbus/auth.rb - About 1 hr to fix

      Method next_state has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

            def next_state(received_words)
        msg = received_words

        case @state
        when :WaitingForData
      Severity: Minor
      Found in lib/dbus/auth.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status