Sign upLogin

mvidner/ruby-dbus

View on GitHub
Star
lib/dbus/connection.rb

Summary

Maintainability
C
1 day
Test Coverage

Method process has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    def process(msg)
      return if msg.nil? # check if somethings wrong

      case msg.message_type
      when Message::ERROR, Message::METHOD_RETURN
Severity: Minor
Found in lib/dbus/connection.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def process(msg)
      return if msg.nil? # check if somethings wrong

      case msg.message_type
      when Message::ERROR, Message::METHOD_RETURN
Severity: Minor
Found in lib/dbus/connection.rb - About 1 hr to fix

    Method send_sync_or_async has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def send_sync_or_async(message, &reply_handler)
      ret = nil
      if reply_handler.nil?
        send_sync(message) do |rmsg|
          raise rmsg if rmsg.is_a?(Error)
    Severity: Minor
    Found in lib/dbus/connection.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method emit has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def emit(_service, obj, intf, sig, *args)
    Severity: Minor
    Found in lib/dbus/connection.rb - About 35 mins to fix

      Method send_sync has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def send_sync(msg, &retc) # :yields: reply/return message
      return if msg.nil? # check if somethings wrong

      @message_queue.push(msg)
      @method_call_msgs[msg.serial] = msg
      Severity: Minor
      Found in lib/dbus/connection.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status