Sign upLogin

mvidner/ruby-dbus

View on GitHub
Star
lib/dbus/message.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method unmarshall_buffer has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def unmarshall_buffer(buf)
      pu = PacketUnmarshaller.new(buf, RawMessage.endianness(buf[0]))
      mdata = pu.unmarshall(MESSAGE_SIGNATURE)
      _, @message_type, @flags, @protocol, @body_length, @serial,
        headers = mdata
Severity: Minor
Found in lib/dbus/message.rb - About 1 hr to fix

    Method marshall has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def marshall
      if @path == RESERVED_PATH
        # the bus would disconnect us, better explain why
        raise "Cannot send a message with the reserved path #{RESERVED_PATH}: #{inspect}"
      end
    Severity: Minor
    Found in lib/dbus/message.rb - About 1 hr to fix

      Method marshall has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def marshall
      if @path == RESERVED_PATH
        # the bus would disconnect us, better explain why
        raise "Cannot send a message with the reserved path #{RESERVED_PATH}: #{inspect}"
      end
      Severity: Minor
      Found in lib/dbus/message.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status