mvondracek/PA193_mnemonic_Slytherin

View on GitHub

Showing 22 of 37 total issues

TODO found
Confirmed

        # TODO Should we support multiple dictionaries for various languages?
Severity: Minor
Found in pa193mnemonicslytherin/mnemonic.py by fixme

Method "__init__" has 10 parameters, which is greater than the 7 authorized.
Confirmed

    def __init__(self,
                 logging_level: int,
                 entropy_filepath: str,
                 seed_filepath: str,
                 mnemonic_filepath: str,

A long parameter list can indicate that a new structure should be created to wrap the numerous parameters or that the function is doing too many things.

Noncompliant Code Example

With a maximum number of 4 parameters:

def do_something(param1, param2, param3, param4, param5):
    ...

Compliant Solution

def do_something(param1, param2, param3, param4):
    ...
Severity
Category
Status
Source
Language