myfreecomm/rexpense-client-ruby

View on GitHub
lib/rexpense/resources/nested_endpoints/comment.rb

Summary

Maintainability
A
0 mins
Test Coverage

Unused block argument - response. You can omit the argument if you don't care about it.
Open

      http.delete("#{comment_endpoint(resource_id)}/#{comment_id}") do |response|

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

Use nested module/class definitions instead of compact style.
Open

module Rexpense::Resources

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

There are no issues that match your filters.

Category
Status