Sign upLogin

myfreecomm/rexpense-client-ruby

View on GitHub
Star
lib/rexpense/resources/nested_endpoints/membership.rb

Summary

Maintainability
A
0 mins
Test Coverage

Use nested module/class definitions instead of compact style.
Open

module Rexpense::Resources
Severity: Minor
Found in lib/rexpense/resources/nested_endpoints/membership.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

Pass &:parsed_body as an argument to post instead of a block.
Open

      http.post(membership_endpoint(organization_id), body: params) do |response|
        response.parsed_body
      end
Severity: Minor
Found in lib/rexpense/resources/nested_endpoints/membership.rb by rubocop

Use symbols as procs when possible.

Example:

# bad
something.map { |s| s.upcase }

# good
something.map(&:upcase)

Unused block argument - response. You can omit the argument if you don't care about it.
Open

      http.delete("#{membership_endpoint(organization_id)}/#{membership_id}") do |response|
Severity: Minor
Found in lib/rexpense/resources/nested_endpoints/membership.rb by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

There are no issues that match your filters.

Category
Status