Sign upLogin

myfreecomm/rexpense-client-ruby

View on GitHub
Star
lib/rexpense/response.rb

Summary

Maintainability
A
25 mins
Test Coverage

Method resolve! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def resolve!
      if success?
        block_given? ? yield(self) : self
      elsif timed_out?
        raise RequestTimeout
Severity: Minor
Found in lib/rexpense/response.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Inherit from RuntimeError instead of Exception.
Open

  class RequestError < Exception; end
Severity: Minor
Found in lib/rexpense/response.rb by rubocop

This cop looks for error classes inheriting from Exception and its standard library subclasses, excluding subclasses of StandardError. It is configurable to suggest using either RuntimeError (default) or StandardError instead.

Example: EnforcedStyle: runtime_error (default)

# bad

class C < Exception; end

# good

class C < RuntimeError; end

Example: EnforcedStyle: standard_error

# bad

class C < Exception; end

# good

class C < StandardError; end

Inherit from RuntimeError instead of Exception.
Open

  class RequestTimeout < Exception; end
Severity: Minor
Found in lib/rexpense/response.rb by rubocop

This cop looks for error classes inheriting from Exception and its standard library subclasses, excluding subclasses of StandardError. It is configurable to suggest using either RuntimeError (default) or StandardError instead.

Example: EnforcedStyle: runtime_error (default)

# bad

class C < Exception; end

# good

class C < RuntimeError; end

Example: EnforcedStyle: standard_error

# bad

class C < Exception; end

# good

class C < StandardError; end

There are no issues that match your filters.

Category
Status