Showing 20 of 20 total issues
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function completeOrders()
{
Mage::helper('payture')->addLog('Start of cron run');
$collection = Mage::getModel('payture/keys')->getCollection();
$collection->addFieldToFilter('sessionid', array('neq' => null));
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 193.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function fivemin()
{
Mage::helper('payture')->addLog('Start of cron run');
$collection = Mage::getModel('payture/keys')->getCollection();
$collection->addFieldToFilter('sessionid', array('neq' => null));
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 193.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function paynowAction
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
public function paynowAction()
{
$session = Mage::getSingleton('checkout/session');
//сессия
$enc_key = $this->getRequest()->getParam('order');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method addtransaction
has 49 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function addtransaction($order)
{
$orders = Mage::getModel('sales/order_invoice')->getCollection()
->addAttributeToFilter('order_id', array('eq' => $order->getId()));
$orders->getSelect()->limit(1);
Method initSession
has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function initSession($order, $enc_key, $itemid)
{
$paytype = Mage::getStoreConfig('payment/payture/paytype');
$request = array(
'SessionType' => $paytype,
Method paynowAction
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function paynowAction()
{
$session = Mage::getSingleton('checkout/session');
//сессия
$enc_key = $this->getRequest()->getParam('order');
Method buildFinalArray
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function buildFinalArray()
{
$grandTotal = $this->_entity->getData('grand_total');
$items = $this->getAllItems();
Function addtransaction
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
public function addtransaction($order)
{
$orders = Mage::getModel('sales/order_invoice')->getCollection()
->addAttributeToFilter('order_id', array('eq' => $order->getId()));
$orders->getSelect()->limit(1);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method applyDiscount
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function applyDiscount()
{
$subTotal = $this->_entity->getData('subtotal_incl_tax');
$shippingAmount = $this->_entity->getData('shipping_incl_tax');
$grandTotal = $this->_entity->getData('grand_total');
Function frameAction
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
public function frameAction()
{
if ($this->getRequest()->isPost()) {
$postData = Mage::app()->getRequest()->getPost();
if (!Mage::getModel('payture/payture')->checkSign($postData['orderid'], $postData['hash'])) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method checkSpread
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function checkSpread()
{
$items = $this->getAllItems();
$sum = 0.00;
Method getOrderItemsJson
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getOrderItemsJson($entity)
{
$shippingTax = Mage::getStoreConfig('payment/payture/shipping_tax');
$taxValue = Mage::getStoreConfig('payment/payture/tax_options');
$attributeCode = '';
Method frameAction
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function frameAction()
{
if ($this->getRequest()->isPost()) {
$postData = Mage::app()->getRequest()->getPost();
if (!Mage::getModel('payture/payture')->checkSign($postData['orderid'], $postData['hash'])) {
Function initSession
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
private function initSession($order, $enc_key, $itemid)
{
$paytype = Mage::getStoreConfig('payment/payture/paytype');
$request = array(
'SessionType' => $paytype,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function applyDiscount
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
public function applyDiscount()
{
$subTotal = $this->_entity->getData('subtotal_incl_tax');
$shippingAmount = $this->_entity->getData('shipping_incl_tax');
$grandTotal = $this->_entity->getData('grand_total');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getRecalculated
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function getRecalculated($entity, $taxValue = '', $taxAttributeCode = '', $shippingTaxValue = '', $spreadDiscOnAllUnits = false)
Function checkSpread
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function checkSpread()
{
$items = $this->getAllItems();
$sum = 0.00;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return;
Avoid too many return
statements within this method. Open
return $this->response;
Avoid too many return
statements within this method. Open
return;