Sign upLogin

mygento/payture

View on GitHub
Star

Showing 18 of 20 total issues

Function paynowAction has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public function paynowAction()
    {
        $session = Mage::getSingleton('checkout/session');
        //сессия
        $enc_key = $this->getRequest()->getParam('order');
Severity: Minor
Found in app/code/community/Mygento/Payture/controllers/PaymentController.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method addtransaction has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function addtransaction($order)
    {
        $orders = Mage::getModel('sales/order_invoice')->getCollection()
            ->addAttributeToFilter('order_id', array('eq' => $order->getId()));
        $orders->getSelect()->limit(1);
Severity: Minor
Found in app/code/community/Mygento/Payture/Helper/Data.php - About 1 hr to fix

    Method initSession has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function initSession($order, $enc_key, $itemid)
    {
        $paytype  = Mage::getStoreConfig('payment/payture/paytype');
        $request  = array(
            'SessionType'     => $paytype,
    Severity: Minor
    Found in app/code/community/Mygento/Payture/Model/Payture.php - About 1 hr to fix

      Method paynowAction has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function paynowAction()
    {
        $session = Mage::getSingleton('checkout/session');
        //сессия
        $enc_key = $this->getRequest()->getParam('order');
      Severity: Minor
      Found in app/code/community/Mygento/Payture/controllers/PaymentController.php - About 1 hr to fix

        Method buildFinalArray has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function buildFinalArray()
    {
        $grandTotal = $this->_entity->getData('grand_total');

        $items      = $this->getAllItems();
        Severity: Minor
        Found in app/code/community/Mygento/Payture/Helper/Discount.php - About 1 hr to fix

          Function addtransaction has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              public function addtransaction($order)
    {
        $orders = Mage::getModel('sales/order_invoice')->getCollection()
            ->addAttributeToFilter('order_id', array('eq' => $order->getId()));
        $orders->getSelect()->limit(1);
          Severity: Minor
          Found in app/code/community/Mygento/Payture/Helper/Data.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method applyDiscount has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function applyDiscount()
    {
        $subTotal       = $this->_entity->getData('subtotal_incl_tax');
        $shippingAmount = $this->_entity->getData('shipping_incl_tax');
        $grandTotal     = $this->_entity->getData('grand_total');
          Severity: Minor
          Found in app/code/community/Mygento/Payture/Helper/Discount.php - About 1 hr to fix

            Function frameAction has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                public function frameAction()
    {
        if ($this->getRequest()->isPost()) {
            $postData = Mage::app()->getRequest()->getPost();
            if (!Mage::getModel('payture/payture')->checkSign($postData['orderid'], $postData['hash'])) {
            Severity: Minor
            Found in app/code/community/Mygento/Payture/controllers/ApiController.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method checkSpread has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function checkSpread()
    {
        $items = $this->getAllItems();

        $sum                    = 0.00;
            Severity: Minor
            Found in app/code/community/Mygento/Payture/Helper/Discount.php - About 1 hr to fix

              Method getOrderItemsJson has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function getOrderItemsJson($entity)
    {
        $shippingTax   = Mage::getStoreConfig('payment/payture/shipping_tax');
        $taxValue      = Mage::getStoreConfig('payment/payture/tax_options');
        $attributeCode = '';
              Severity: Minor
              Found in app/code/community/Mygento/Payture/Helper/Data.php - About 1 hr to fix

                Method frameAction has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function frameAction()
    {
        if ($this->getRequest()->isPost()) {
            $postData = Mage::app()->getRequest()->getPost();
            if (!Mage::getModel('payture/payture')->checkSign($postData['orderid'], $postData['hash'])) {
                Severity: Minor
                Found in app/code/community/Mygento/Payture/controllers/ApiController.php - About 1 hr to fix

                  Function initSession has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function initSession($order, $enc_key, $itemid)
    {
        $paytype  = Mage::getStoreConfig('payment/payture/paytype');
        $request  = array(
            'SessionType'     => $paytype,
                  Severity: Minor
                  Found in app/code/community/Mygento/Payture/Model/Payture.php - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function applyDiscount has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function applyDiscount()
    {
        $subTotal       = $this->_entity->getData('subtotal_incl_tax');
        $shippingAmount = $this->_entity->getData('shipping_incl_tax');
        $grandTotal     = $this->_entity->getData('grand_total');
                  Severity: Minor
                  Found in app/code/community/Mygento/Payture/Helper/Discount.php - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method getRecalculated has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public function getRecalculated($entity, $taxValue = '', $taxAttributeCode = '', $shippingTaxValue = '', $spreadDiscOnAllUnits = false)
                  Severity: Minor
                  Found in app/code/community/Mygento/Payture/Helper/Discount.php - About 35 mins to fix

                    Function checkSpread has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function checkSpread()
    {
        $items = $this->getAllItems();

        $sum                    = 0.00;
                    Severity: Minor
                    Found in app/code/community/Mygento/Payture/Helper/Discount.php - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid too many return statements within this method.
                    Open

                                return;
                    Severity: Major
                    Found in app/code/community/Mygento/Payture/controllers/PaymentController.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return $this->response;
                      Severity: Major
                      Found in app/code/community/Mygento/Payture/controllers/ApiController.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                        return;
                        Severity: Major
                        Found in app/code/community/Mygento/Payture/controllers/PaymentController.php - About 30 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language