Method collectRates has 59 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function collectRates(Mage_Shipping_Model_Rate_Request $request)
    {
        Varien_Profiler::start($this->_name . '_collect_rate');

        if (!$this->getType()) {

Method processType has 42 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;

Function processType has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;

• Read up
  Read up

Function collectRates has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

    public function collectRates(Mage_Shipping_Model_Rate_Request $request)
    {
        Varien_Profiler::start($this->_name . '_collect_rate');

        if (!$this->getType()) {

• Read up
  Read up

The method collectRates uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $quote = $this->getQuote();
            $cartItems = $quote->getAllVisibleItems();

            Mage::helper($this->_name)->addLog('Found ' . count($cartItems) . ' items in quote');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The class Mygento_Yandexdelivery_Model_Shipping is not named in CamelCase.

Open

class Mygento_Yandexdelivery_Model_Shipping extends Mage_Shipping_Model_Carrier_Abstract implements Mage_Shipping_Model_Carrier_Interface
{

    protected $_name = 'yandexdelivery';
    protected $_isFixed = false;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class class_name {
}

The property $_isFixed is not named in camelCase.

Open

class Mygento_Yandexdelivery_Model_Shipping extends Mage_Shipping_Model_Carrier_Abstract implements Mage_Shipping_Model_Carrier_Interface
{

    protected $_name = 'yandexdelivery';
    protected $_isFixed = false;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    protected $property_name;
}

The property $_name is not named in camelCase.

Open

class Mygento_Yandexdelivery_Model_Shipping extends Mage_Shipping_Model_Carrier_Abstract implements Mage_Shipping_Model_Carrier_Interface
{

    protected $_name = 'yandexdelivery';
    protected $_isFixed = false;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    protected $property_name;
}

The variable $processed_dimensions is not named in camelCase.

Open

    public function collectRates(Mage_Shipping_Model_Rate_Request $request)
    {
        Varien_Profiler::start($this->_name . '_collect_rate');

        if (!$this->getType()) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $carrier_offer is not named in camelCase.

Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $carrier_offer is not named in camelCase.

Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $carrier_offer is not named in camelCase.

Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $error_text is not named in camelCase.

Open

    public function collectRates(Mage_Shipping_Model_Rate_Request $request)
    {
        Varien_Profiler::start($this->_name . '_collect_rate');

        if (!$this->getType()) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $carrier_offer is not named in camelCase.

Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $carrier_offer is not named in camelCase.

Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $carrier_offer is not named in camelCase.

Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $carrier_offer is not named in camelCase.

Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $carrier_offer is not named in camelCase.

Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $error_text is not named in camelCase.

Open

    public function collectRates(Mage_Shipping_Model_Rate_Request $request)
    {
        Varien_Profiler::start($this->_name . '_collect_rate');

        if (!$this->getType()) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $carrier_offer is not named in camelCase.

Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $carrier_offer is not named in camelCase.

Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $carrier_offer is not named in camelCase.

Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $carrier_offer is not named in camelCase.

Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $processed_dimensions is not named in camelCase.

Open

    public function collectRates(Mage_Shipping_Model_Rate_Request $request)
    {
        Varien_Profiler::start($this->_name . '_collect_rate');

        if (!$this->getType()) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $processed_dimensions is not named in camelCase.

Open

    public function collectRates(Mage_Shipping_Model_Rate_Request $request)
    {
        Varien_Profiler::start($this->_name . '_collect_rate');

        if (!$this->getType()) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $carrier_offer is not named in camelCase.

Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $carrier_offer is not named in camelCase.

Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $error_text is not named in camelCase.

Open

    public function collectRates(Mage_Shipping_Model_Rate_Request $request)
    {
        Varien_Profiler::start($this->_name . '_collect_rate');

        if (!$this->getType()) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $carrier_offer is not named in camelCase.

Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $carrier_offer is not named in camelCase.

Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

The variable $carrier_offer is not named in camelCase.

Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}