mygento/yandexdelivery

View on GitHub
app/code/local/Mygento/Yandexdelivery/Model/Source/Attribute.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid excessively long class names like Mygento_Yandexdelivery_Model_Source_Attribute. Keep class name length under 40.
Open

class Mygento_Yandexdelivery_Model_Source_Attribute
{

    public function getAllOptions()
    {

LongClassName

Since: 2.9

Detects when classes or interfaces are declared with excessively long names.

Example

class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

Source https://phpmd.org/rules/naming.html#longclassname

The class Mygento_Yandexdelivery_Model_Source_Attribute is not named in CamelCase.
Open

class Mygento_Yandexdelivery_Model_Source_Attribute
{

    public function getAllOptions()
    {

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

The variable $_options is not named in camelCase.
Open

    public function getAllOptions()
    {
        $attributes = Mage::getModel('eav/config')->getEntityType(Mage_Catalog_Model_Product::ENTITY)->getAttributeCollection();
        $attributes->setOrder('frontend_label', 'ASC');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_options is not named in camelCase.
Open

    public function getAllOptions()
    {
        $attributes = Mage::getModel('eav/config')->getEntityType(Mage_Catalog_Model_Product::ENTITY)->getAttributeCollection();
        $attributes->setOrder('frontend_label', 'ASC');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_options is not named in camelCase.
Open

    public function getAllOptions()
    {
        $attributes = Mage::getModel('eav/config')->getEntityType(Mage_Catalog_Model_Product::ENTITY)->getAttributeCollection();
        $attributes->setOrder('frontend_label', 'ASC');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_options is not named in camelCase.
Open

    public function getAllOptions()
    {
        $attributes = Mage::getModel('eav/config')->getEntityType(Mage_Catalog_Model_Product::ENTITY)->getAttributeCollection();
        $attributes->setOrder('frontend_label', 'ASC');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status