Showing 262 of 262 total issues
Avoid excessively long class names like Mygento_Yandexdelivery_Block_Adminhtml_Shipment. Keep class name length under 40. Open
class Mygento_Yandexdelivery_Block_Adminhtml_Shipment extends Mage_Adminhtml_Block_Widget_Grid_Container
{
public function _construct()
{- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}Source https://phpmd.org/rules/naming.html#longclassname
Avoid excessively long class names like Mygento_Yandexdelivery_Model_Resource_Requisite. Keep class name length under 40. Open
class Mygento_Yandexdelivery_Model_Resource_Requisite extends Mage_Core_Model_Resource_Db_Abstract
{
public function _construct()
{- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}Source https://phpmd.org/rules/naming.html#longclassname
Avoid excessively long class names like Mygento_Yandexdelivery_Model_Source_Payment. Keep class name length under 40. Open
class Mygento_Yandexdelivery_Model_Source_Payment
{
public function toOptionArray()
{- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}Source https://phpmd.org/rules/naming.html#longclassname
Avoid excessively long class names like Mygento_Yandexdelivery_Model_Resource_Sender. Keep class name length under 40. Open
class Mygento_Yandexdelivery_Model_Resource_Sender extends Mage_Core_Model_Resource_Db_Abstract
{
public function _construct()
{- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}Source https://phpmd.org/rules/naming.html#longclassname
Avoid excessively long class names like Mygento_Yandexdelivery_Model_Source_Weight. Keep class name length under 40. Open
class Mygento_Yandexdelivery_Model_Source_Weight
{
public function toOptionArray()
{- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}Source https://phpmd.org/rules/naming.html#longclassname
Avoid excessively long class names like Mygento_Yandexdelivery_Adminhtml_Yandexdelivery_ApiController. Keep class name length under 40. Open
class Mygento_Yandexdelivery_Adminhtml_Yandexdelivery_ApiController extends Mage_Adminhtml_Controller_Action
{
public function sendAction()
{- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}Source https://phpmd.org/rules/naming.html#longclassname
Avoid excessively long class names like Mygento_Yandexdelivery_Model_Carrier_Todoor. Keep class name length under 40. Open
class Mygento_Yandexdelivery_Model_Carrier_Todoor extends Mygento_Yandexdelivery_Model_Shipping
{
protected $_subcode = 'todoor';
- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}Source https://phpmd.org/rules/naming.html#longclassname
Avoid excessively long class names like Mygento_Yandexdelivery_Model_Resource_Warehouse. Keep class name length under 40. Open
class Mygento_Yandexdelivery_Model_Resource_Warehouse extends Mage_Core_Model_Resource_Db_Abstract
{
public function _construct()
{- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}Source https://phpmd.org/rules/naming.html#longclassname
Avoid excessively long class names like Mygento_Yandexdelivery_Model_Resource_Shipment. Keep class name length under 40. Open
class Mygento_Yandexdelivery_Model_Resource_Shipment extends Mage_Core_Model_Resource_Db_Abstract
{
public function _construct()
{- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}Source https://phpmd.org/rules/naming.html#longclassname
Avoid excessively long class names like Mygento_Yandexdelivery_Model_Resource_Warehouse_Collection. Keep class name length under 40. Open
class Mygento_Yandexdelivery_Model_Resource_Warehouse_Collection extends Mage_Core_Model_Resource_Db_Collection_Abstract
{
public function _construct()
{- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}Source https://phpmd.org/rules/naming.html#longclassname
Avoid excessively long class names like Mygento_Yandexdelivery_Model_Resource_Sender_Collection. Keep class name length under 40. Open
class Mygento_Yandexdelivery_Model_Resource_Sender_Collection extends Mage_Core_Model_Resource_Db_Collection_Abstract
{
public function _construct()
{- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}Source https://phpmd.org/rules/naming.html#longclassname
Function getSizes has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function getSizes($items, $is_quote)
{
$temporary_dimensions = [];
$weight = 0;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getTable has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getTable()
{
//таблица с статусами заказа
if (!$this->hasYdId()) {Method processApiIds has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function processApiIds($data_string) {
$json = json_decode(trim($data_string));
$res = Mage::getSingleton('core/resource');
Identical blocks of code found in 2 locations. Consider refactoring. Open
success: function (data) {
response(jQuery.map(data.jsonresult, function (item) {
return {
label: item.label,
value: item.value- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 59.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
success: function (data) {
response(jQuery.map(data.jsonresult, function (item) {
return {
label: item.label,
value: item.value- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 59.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Avoid using undefined variables such as '$warehouseId' which will lead to PHP notices. Open
Mage::getModel('yandexdelivery/carrier')->updateOrder($orderId, $warehouseId, $senderId, $requisiteId);- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$requisiteId' which will lead to PHP notices. Open
Mage::getModel('yandexdelivery/carrier')->updateOrder($orderId, $warehouseId, $senderId, $requisiteId);- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$ch' which will lead to PHP notices. Open
$this->addLog(curl_error($ch));- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid using undefined variables such as '$senderId' which will lead to PHP notices. Open
Mage::getModel('yandexdelivery/carrier')->updateOrder($orderId, $warehouseId, $senderId, $requisiteId);- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}