Sign upLogin

mylisabox/lisa-plugins-manager

View on GitHub
Star

Showing 5 of 5 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      settings: {
        type: Sequelize.TEXT,
        get: function () {
          let data = this.getDataValue('settings')
          if (_.isString(data)) {
Severity: Major
Found in api/models/Plugin.js and 1 other location - About 5 hrs to fix
api/models/Plugin.js on lines 57..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 135.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      devicesSettings: {
        type: Sequelize.TEXT,
        get: function () {
          let data = this.getDataValue('devicesSettings')
          if (_.isString(data)) {
Severity: Major
Found in api/models/Plugin.js and 1 other location - About 5 hrs to fix
api/models/Plugin.js on lines 39..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 135.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function schema has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  static schema(app, Sequelize) {
    return {
      internalName: {
        type: Sequelize.STRING,
        allowNull: false
Severity: Major
Found in api/models/Plugin.js - About 3 hrs to fix

    Function schema has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      static schema(app, Sequelize) {
    return {
      internalName: {
        type: Sequelize.STRING,
        allowNull: false
    Severity: Minor
    Found in api/models/Plugin.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function installPlugin has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      installPlugin(name, version = 'master', from = 'github') {
    let url

    switch (from) {
    case 'npm':
    Severity: Minor
    Found in api/services/PluginService.js - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language