Sign upLogin

mylisabox/trailpack-chatbot

View on GitHub
Star

Showing 20 of 20 total issues

Function _searchMatch has a Cognitive Complexity of 65 (exceeds 5 allowed). Consider refactoring.
Open

  _searchMatch(bot, stateData, lang, userSentence, sentences) {
    let results = null
    if (sentences[lang]) {
      for (let j = 0; j < sentences[lang].length; j++) {
        const sentenceData = sentences[lang][j]
Severity: Minor
Found in api/services/ChatBotService.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File ChatBotService.js has 391 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict'

const Service = require('trails/service')
const _ = require('lodash')
Severity: Minor
Found in api/services/ChatBotService.js - About 5 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          data: {
        type: Sequelize.STRING,
        get: function () {
          let data = null
          if (this.getDataValue('data')) {
    Severity: Major
    Found in api/models/ChatBot.js and 1 other location - About 4 hrs to fix
    api/models/ChatBot.js on lines 48..66

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 132.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          originalData: {
        type: Sequelize.STRING,
        get: function () {
          let data = null
          if (this.getDataValue('originalData')) {
    Severity: Major
    Found in api/models/ChatBot.js and 1 other location - About 4 hrs to fix
    api/models/ChatBot.js on lines 29..47

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 132.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function interact has 92 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      interact(userId, lang, userSentence, chatBotId) {
    if (!userId && !this.app.config.chatbot.allowAnonymousUsers) {
      return Promise.reject('No user provided')
    }
    Severity: Major
    Found in api/services/ChatBotService.js - About 3 hrs to fix

      Function _prepareChatBot has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _prepareChatBot(botId, botData) {
    let data
    if (botData.originalData) {
      botData.data.links = botData.originalData.links
      botData.data.freeStates = botData.originalData.freeStates
      Severity: Major
      Found in api/services/ChatBotService.js - About 2 hrs to fix

        Function schema has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          static schema(app, Sequelize) {
    return {
      name: {
        type: Sequelize.STRING,
        primaryKey: true,
        Severity: Major
        Found in api/models/ChatBot.js - About 2 hrs to fix

          Function _searchMatch has 51 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            _searchMatch(bot, stateData, lang, userSentence, sentences) {
    let results = null
    if (sentences[lang]) {
      for (let j = 0; j < sentences[lang].length; j++) {
        const sentenceData = sentences[lang][j]
          Severity: Major
          Found in api/services/ChatBotService.js - About 2 hrs to fix

            Function init has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              init(initialData) {
    this.botCache = this.app.services.CacheService.getStore('chatbot')
    initialData = _.cloneDeep(initialData)
    this.chatBots = []
    return this._prepareParams().then(() => this.app.orm.ChatBot.findAll({
            Severity: Minor
            Found in api/services/ChatBotService.js - About 1 hr to fix

              Function reloadBots has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                reloadBots() {
    return this._prepareParams().then(() => this.app.orm.ChatBot.findAll({
      where: {
        enabled: true
      }
              Severity: Minor
              Found in api/services/ChatBotService.js - About 1 hr to fix

                Function _prepareParam has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  _prepareParam(key, value) {
    if (Array.isArray(value)) {
      mapParams[key] = `(${value.join('|')})`
    }
    else if (_.isFunction(value)) {
                Severity: Minor
                Found in api/services/ChatBotService.js - About 1 hr to fix

                  Function schema has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                    static schema(app, Sequelize) {
    return {
      name: {
        type: Sequelize.STRING,
        primaryKey: true,
                  Severity: Minor
                  Found in api/models/ChatBot.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function _prepareParam has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                    _prepareParam(key, value) {
    if (Array.isArray(value)) {
      mapParams[key] = `(${value.join('|')})`
    }
    else if (_.isFunction(value)) {
                  Severity: Minor
                  Found in api/services/ChatBotService.js - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid deeply nested control flow statements.
                  Open

                              for (let i = 1; i < matches.length; i++) {
              let value = matches[i]
              const type = sentenceData.fields[i - 1]
              const param = this.app.config.chatbot.params[type]
              if (type.indexOf('number') !== -1) {
                  Severity: Major
                  Found in api/services/ChatBotService.js - About 45 mins to fix

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if (userId) {
              this.botCache.set(userId + '_data', result, (err) => {
                if (err) {
                  reject(err)
                }
                    Severity: Minor
                    Found in api/services/ChatBotService.js and 1 other location - About 45 mins to fix
                    api/services/ChatBotService.js on lines 448..458

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 50.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Avoid deeply nested control flow statements.
                    Open

                                    if (result) {
                  break
                }
                    Severity: Major
                    Found in api/services/ChatBotService.js - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                        if (hook) {
                    hook(this.app, publicResult).then(resolve).catch(reject)
                  }
                  else {
                    resolve(publicResult)
                      Severity: Major
                      Found in api/services/ChatBotService.js - About 45 mins to fix

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                                        if (err) {
                  reject(err)
                }
                else {
                  if (hook) {
                        Severity: Minor
                        Found in api/services/ChatBotService.js and 1 other location - About 45 mins to fix
                        api/services/ChatBotService.js on lines 446..468

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 50.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                    updates.push(this.app.orm.ChatBot.update(bot, { where: { name: bot.name } }))
                        Severity: Minor
                        Found in api/services/ChatBotService.js and 1 other location - About 40 mins to fix
                        api/services/ChatBotService.js on lines 270..277

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 48.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                  bots.push(this.app.orm.ChatBot.update(
            data,
            {
              where: {
                name: botData.name
                        Severity: Minor
                        Found in api/services/ChatBotService.js and 1 other location - About 40 mins to fix
                        api/services/ChatBotService.js on lines 189..189

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 48.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Severity
                        Category
                        Status
                        Source
                        Language