myronmarston/vcr

View on GitHub
lib/vcr/cassette/migrator.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method migrate_cassette has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def migrate_cassette(cassette)
        unless http_interactions = load_yaml(cassette)
          @out.puts "  - Ignored #{relative_casssette_name(cassette)} since it could not be parsed as YAML (does it have some ERB?)"
          return
        end
Severity: Minor
Found in lib/vcr/cassette/migrator.rb - About 1 hr to fix

    Method remove_unnecessary_standard_port has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def remove_unnecessary_standard_port(interaction)
            uri = VCR.configuration.uri_parser.parse(interaction.request.uri)
            if uri.scheme == 'http'  && uri.port == 80 ||
               uri.scheme == 'https' && uri.port == 443
              uri.port = nil
    Severity: Minor
    Found in lib/vcr/cassette/migrator.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status