Showing 277 of 434 total issues
Method display_status
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def display_status
if is_incoming_message?
status = calculated_state
return status.nil? ? _("Response") : InfoRequest.get_status_description(status)
end
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method download_entire_request
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def download_entire_request
AlaveteliLocalization.with_locale(locale) do
@info_request = InfoRequest.find_by_url_title!(params[:url_title])
# Check for access and hide emargoed requests immediately, so that we
# don't leak any info to people who can't access them
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method excerpt
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def excerpt(text, phrase, options = {})
return unless text && phrase
separator = options.fetch(:separator, nil) || ""
case phrase
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method words_to_highlight
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def words_to_highlight(opts = {})
default_opts = { include_original: false, regex: false }
opts = default_opts.merge(opts)
# Reject all prefixes other than Z, which we know is reserved for stems
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method tnef_attachments
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def tnef_attachments(content)
attachments = []
Dir.mktmpdir do |dir|
IO.popen("tnef -K -C #{dir} 2> /dev/null", "wb") do |f|
f.write(content)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method init_terms
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def self.init_terms(terms)
terms.each do |_method, term_code, prefix|
unless term_code.match(/^[A-Z]$/)
raise "Use a single capital letter for term code"
end
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method body_request_events
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def body_request_events
feed_type = params[:feed_type]
if @public_body.id != params[:id].to_i
raise PermissionDenied, "#{@public_body.id} != #{params[:id]}"
end
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method is_oof?
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def self.is_oof?(message)
# Check for out-of-office
if MailHandler.get_header_string("X-POST-MessageClass", message) == "9; Autoresponder"
return true
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method event_description
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
def event_description(event)
body_link = public_body_link_absolute(event.info_request.public_body)
user_link = request_user_link_absolute(event.info_request)
date = simple_date(event.created_at)
case event.event_type
Method redeliver
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
def redeliver
message_ids = params[:url_title].split(',').map(&:strip)
previous_request = @incoming_message.info_request
destination_request = nil
Method wall
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
def wall
long_cache
@display_user = set_display_user
@is_you = current_user_is_display_user
feed_results = Set.new
Method signup
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
def signup
# Make the user and try to save it
@user_signup = User.new(user_params(:user_signup))
error = false
if @request_from_foreign_country && !verify_recaptcha
Method remove_quoted_sections
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.remove_quoted_sections(text, replacement = "FOLDED_QUOTED_SECTION")
text = text.dup
replacement = "\n" + replacement + "\n"
# First do this peculiar form of quoting, as the > single line quoting
Method update
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
def update
@pretoken_redirect = PostRedirect.find_by(token: @pretoken) if @pretoken
if @password_change_user
@password_change_user.password = params[:password_change_user][:password]
Method alert_not_clarified_request
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.alert_not_clarified_request
info_requests = InfoRequest.
where("awaiting_description = ?
AND described_state = 'waiting_clarification'
AND info_requests.updated_at < ?
Method hide
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
def hide
ActiveRecord::Base.transaction do
subject = params[:subject]
explanation = params[:explanation]
Method assign_variables_for_show_template
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
def assign_variables_for_show_template(info_request)
@info_request = info_request
@status = info_request.calculate_status
@old_unclassified =
info_request.is_old_unclassified? && authenticated?
Method stop_new_responses_on_old_requests
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.stop_new_responses_on_old_requests
# 'old' months since last change to request, only allow new incoming
# messages from authority domains
InfoRequest.
been_published.
Method alert_new_response_reminders_internal
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.alert_new_response_reminders_internal(days_since, type_code)
info_requests = InfoRequest.
where_old_unclassified(days_since).
where(use_notifications: false).
order(:id).
Method create_request
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
def create_request
json = ActiveSupport::JSON.decode(params[:request_json])
request = InfoRequest.new(
title: json["title"],
public_body_id: @public_body.id,