mysociety/alaveteli

View on GitHub

Showing 629 of 632 total issues

Function Plot has 1911 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function Plot(placeholder, data_, options_, plugins) {
        // data is on the form:
        //   [ series1, series2 ... ]
        // where series is either just the data as [ [x1, y1], [x2, y2], ... ]
        // or { data: [ [x1, y1], [x2, y2], ... ], label: "some label", ... }
Severity: Major
Found in app/assets/javascripts/jquery.flot.js - About 1 wk to fix

    File selectize.js has 2497 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
     * sifter.js
     * Copyright (c) 2013 Brian Reavis & contributors
     *
     * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this
    Severity: Major
    Found in app/assets/javascripts/alaveteli_pro/selectize.js - About 6 days to fix

      File jquery.flot.js has 2154 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /* Javascript plotting library for jQuery, version 0.8.2-alpha.
      
      Copyright (c) 2007-2013 IOLA and Ole Laursen.
      Licensed under the MIT license.
      
      
      Severity: Major
      Found in app/assets/javascripts/jquery.flot.js - About 5 days to fix

        File info_request.rb has 1331 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        require 'digest/sha1'
        require 'fileutils'
        
        class InfoRequest < ActiveRecord::Base
          OLD_AGE_IN_DAYS = 21.days
        Severity: Major
        Found in app/models/info_request.rb - About 3 days to fix

          Class InfoRequest has 139 methods (exceeds 20 allowed). Consider refactoring.
          Open

          class InfoRequest < ActiveRecord::Base
            OLD_AGE_IN_DAYS = 21.days
          
            include AdminColumn
            include Rails.application.routes.url_helpers
          Severity: Major
          Found in app/models/info_request.rb - About 2 days to fix

            File request_controller.rb has 929 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            require 'zip'
            require 'open-uri'
            
            class RequestController < ApplicationController
              before_action :check_read_only, :only => [ :new, :describe_state, :upload_response ]
            Severity: Major
            Found in app/controllers/request_controller.rb - About 2 days to fix

              File acts_as_xapian.rb has 771 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              begin
                require 'xapian'
                $acts_as_xapian_bindings_available = true
              rescue LoadError
                STDERR.puts "acts_as_xapian: No Ruby bindings for Xapian installed"
              Severity: Major
              Found in lib/acts_as_xapian/acts_as_xapian.rb - About 1 day to fix

                File public_body.rb has 692 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                require 'csv'
                require 'securerandom'
                require 'set'
                require 'confidence_intervals'
                
                
                Severity: Major
                Found in app/models/public_body.rb - About 1 day to fix

                  Class User has 71 methods (exceeds 20 allowed). Consider refactoring.
                  Open

                  class User < ActiveRecord::Base
                    include AlaveteliFeatures::Helpers
                    include AlaveteliPro::PhaseCounts
                    include User::Authentication
                  
                  
                  Severity: Major
                  Found in app/models/user.rb - About 1 day to fix

                    File routes.rb has 560 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    include AlaveteliFeatures::Constraints
                    
                    # Allow easy extension from themes. Note these will have the highest priority.
                    $alaveteli_route_extensions.each do |f|
                      load File.join('config', f)
                    Severity: Major
                    Found in config/routes.rb - About 1 day to fix

                      Method table_rows has a Cognitive Complexity of 59 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def table_rows
                            now = ActiveRecord::Base.default_timezone == :utc ? Time.now.utc : Time.now
                            now = now.to_s(:db)
                      
                            # allow a standard key to be used for doing defaults in YAML
                      Severity: Minor
                      Found in lib/fixture_set_table_rows_patch.rb - About 1 day to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      File user.rb has 523 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      class User < ActiveRecord::Base
                        include AlaveteliFeatures::Helpers
                        include AlaveteliPro::PhaseCounts
                        include User::Authentication
                      
                      
                      Severity: Major
                      Found in app/models/user.rb - About 1 day to fix

                        Method xapian_index has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
                        Open

                            def xapian_index(terms = true, values = true, texts = true)
                              # if we have a conditional function for indexing, call it and destroy object if failed
                              if self.class.xapian_options.include?(:if)
                                if_value = xapian_value(self.class.xapian_options[:if], :boolean)
                                if not if_value
                        Severity: Minor
                        Found in lib/acts_as_xapian/acts_as_xapian.rb - About 1 day to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                          var submitRemoveForm = function submitRemoveForm(e) {
                            e.preventDefault();
                            var $this = $(this);
                            DraftBatchSummary.startNewXHR();
                            DraftBatchSummary.currentXHR = $.ajax({
                        app/assets/javascripts/alaveteli_pro/batch_authority_search/result.js on lines 30..51

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 192.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                          var submitAddForm = function submitAddForm(e) {
                            e.preventDefault();
                            var $this = $(this);
                            DraftBatchSummary.startNewXHR();
                            DraftBatchSummary.currentXHR = $.ajax({
                        app/assets/javascripts/alaveteli_pro/draft_batch_summary/body.js on lines 27..47

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 192.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Method alert_tracks has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
                        Open

                          def self.alert_tracks
                            done_something = false
                            now = Time.zone.now
                            one_week_ago = now - 7.days
                            User.where(["last_daily_track_email < ?", now - 1.day ]).find_each do |user|
                        Severity: Minor
                        Found in app/mailers/track_mailer.rb - About 7 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method get_language_name has 191 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          def self.get_language_name(locale)
                            language_names = {
                              'ab'    => 'аҧсуа',
                              'aa'    => 'Afaraf',
                              'af'    => 'Afrikaans',
                        Severity: Major
                        Found in lib/languages.rb - About 7 hrs to fix

                          Function drawSeriesLines has 187 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                  function drawSeriesLines(series) {
                                      function plotLine(datapoints, xoffset, yoffset, axisx, axisy) {
                                          var points = datapoints.points,
                                              ps = datapoints.pointsize,
                                              prevx = null, prevy = null;
                          Severity: Major
                          Found in app/assets/javascripts/jquery.flot.js - About 7 hrs to fix

                            Class PublicBody has 51 methods (exceeds 20 allowed). Consider refactoring.
                            Open

                            class PublicBody < ActiveRecord::Base
                              include AdminColumn
                            
                              class ImportCSVDryRun < StandardError ; end
                            
                            
                            Severity: Major
                            Found in app/models/public_body.rb - About 7 hrs to fix

                              Function drawGrid has 177 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                      function drawGrid() {
                                          var i, axes, bw, bc;
                              
                                          ctx.save();
                                          ctx.translate(plotOffset.left, plotOffset.top);
                              Severity: Major
                              Found in app/assets/javascripts/jquery.flot.js - About 7 hrs to fix
                                Severity
                                Category
                                Status
                                Source
                                Language