Showing 422 of 436 total issues
File info_request.rb
has 1392 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'digest/sha1'
require 'fileutils'
class InfoRequest < ApplicationRecord
OLD_AGE_IN_DAYS = 21.days
Class InfoRequest
has 151 methods (exceeds 20 allowed). Consider refactoring. Open
class InfoRequest < ApplicationRecord
OLD_AGE_IN_DAYS = 21.days
include Rails.application.routes.url_helpers
include AlaveteliPro::RequestSummaries
File acts_as_xapian.rb
has 824 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'English'
begin
require 'xapian'
$acts_as_xapian_bindings_available = true
File public_body.rb
has 721 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'csv'
require 'securerandom'
require 'set'
require 'confidence_intervals'
File routes.rb
has 702 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'sidekiq/web'
include AlaveteliFeatures::Constraints
# Allow easy extension from themes. Note these will have the highest priority.
Class User
has 75 methods (exceeds 20 allowed). Consider refactoring. Open
class User < ApplicationRecord
include AlaveteliFeatures::Helpers
include AlaveteliPro::PhaseCounts
include User::Authentication
include User::LoginToken
File request_controller.rb
has 612 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'zip'
class RequestController < ApplicationController
skip_before_action :html_response, only: [:show, :select_authorities]
Method initialize
has a Cognitive Complexity of 60 (exceeds 5 allowed). Consider refactoring. Open
def initialize(user, project: nil, public_token: false)
# Define abilities for the passed in user here. For example:
#
# user ||= User.new # guest user (not logged in)
# if user.is_admin?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File user.rb
has 528 lines of code (exceeds 250 allowed). Consider refactoring. Open
class User < ApplicationRecord
include AlaveteliFeatures::Helpers
include AlaveteliPro::PhaseCounts
include User::Authentication
include User::LoginToken
Class PublicBody
has 60 methods (exceeds 20 allowed). Consider refactoring. Open
class PublicBody < ApplicationRecord
include CalculatedHomePage
include Categorisable
include Taggable
include Notable
Similar blocks of code found in 2 locations. Consider refactoring. Open
var submitAddForm = function submitAddForm(e) {
e.preventDefault();
var $this = $(this);
DraftBatchSummary.startNewXHR();
DraftBatchSummary.currentXHR = $.ajax({
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 192.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
var submitRemoveForm = function submitRemoveForm(e) {
e.preventDefault();
var $this = $(this);
DraftBatchSummary.startNewXHR();
DraftBatchSummary.currentXHR = $.ajax({
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 192.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method get_language_name
has 191 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.get_language_name(locale)
language_names = {
'ab' => 'аҧсуа',
'aa' => 'Afaraf',
'af' => 'Afrikaans',
File user_controller.rb
has 470 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'set'
class UserController < ApplicationController
include UserSpamCheck
Class OutgoingMessage
has 50 methods (exceeds 20 allowed). Consider refactoring. Open
class OutgoingMessage < ApplicationRecord
include MessageProminence
include Rails.application.routes.url_helpers
include LinkToHelper
include Taggable
Class InfoRequestEvent
has 49 methods (exceeds 20 allowed). Consider refactoring. Open
class InfoRequestEvent < ApplicationRecord
extend XapianQueries
EVENT_TYPES = [
'sent',
File info_request_event.rb
has 445 lines of code (exceeds 250 allowed). Consider refactoring. Open
class InfoRequestEvent < ApplicationRecord
extend XapianQueries
EVENT_TYPES = [
'sent',
Function d3TimeSeries
has 158 lines of code (exceeds 25 allowed). Consider refactoring. Open
function d3TimeSeries(selector, data, title, metric_name) {
// Add the title
var wrapper_element = document.querySelectorAll(selector)[0];
File outgoing_message.rb
has 418 lines of code (exceeds 250 allowed). Consider refactoring. Open
class OutgoingMessage < ApplicationRecord
include MessageProminence
include Rails.application.routes.url_helpers
include LinkToHelper
include Taggable
Method xapian_index
has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring. Open
def xapian_index(terms = true, values = true, texts = true)
# if we have a conditional function for indexing, call it and destroy object if failed
if self.class.xapian_options.include?(:if)
if_value = xapian_value(self.class.xapian_options[:if], :boolean)
unless if_value
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"